gh-133656: Remove deprecated `zipimport.zipimporter.load_module` by Wulian233 · Pull Request #133662 · python/cpython · GitHub

Ready review!

Issue: Remove deprecated zipimport.zipimporter.load_module #133656

📚 Documentation preview 📚: https://cpython-previews--133662.org.readthedocs.build/

considering how pyhton imports work, You might have to modify the files that run on import or any references to load_module. This will be a really daunting task for you :( sorry!

@Wulian233 Will review tmrw

This PR seems sound, however I'll approve it after stanfromireland and hugovk resolve their conversation, because I am not sure either if it should or shouldn't be in the devguide either :)

There is some additional sys.path manipulation added to the test case that doesn't look like it should be necessary.

Otherwise this looks good to me.

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

There is some additional sys.path manipulation added to the test case that doesn't look like it should be necessary.

Otherwise this looks good to me.

That's necessary. If these two lines are removed, the test will fail (p1)

with a ModuleNotFoundError because the modules cannot be found. If they are added back, the test passes. We need to make sure Python can find them, which maybe is the negative effect of removing load_module? I'm not an expert for this, and I don't know the underlying reasons for them, sorry

And sys.path.insert is also used in many other places in this file, for example:

https://github.com/Wulian233/cpython/blob/5616e27403799b481f44f96c3a21336fd03941c9/Lib/test/test_zipimport.py#L165

https://github.com/Wulian233/cpython/blob/5616e27403799b481f44f96c3a21336fd03941c9/Lib/test/test_zipimport.py#L373

https://github.com/Wulian233/cpython/blob/5616e27403799b481f44f96c3a21336fd03941c9/Lib/test/test_zipimport.py#L420-L422

@Wulian233 You're right, the importlib.import_module lines were previously only passing because the prior zi.load_module call had left sys.modules["TESTPACK"] populated.

Given that, it makes sense to keep the path manipulation additions, but move them as far down in their respective test cases as possible to still let the everything pass (which should be just before the importlib.import_module line in each case, since the direct instantiation shouldn't care if the zip archive is on sys.path or not, while importlib.import_module does care).

I have made the requested changes; please review again

thanks!

Thanks for making the requested changes!

@ncoghlan: please review the changes made to this pull request.

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM64 Raspbian 3.x (tier-3) has failed when building commit 5c6937a.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1678/builds/742) and take a look at the build logs.
Check if the failure is related to this commit (5c6937a) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1678/builds/742

Failed tests:

test.test_multiprocessing_fork.test_processes

Failed subtests:

test_interrupt - test.test_multiprocessing_fork.test_processes.WithProcessesTestProcess.test_interrupt

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/home/stan/buildarea/3.x.stan-raspbian.nondebug/build/Lib/contextlib.py", line 85, in inner
    return func(*args, **kwds)
  File "/home/stan/buildarea/3.x.stan-raspbian.nondebug/build/Lib/test/_test_multiprocessing.py", line 596, in test_interrupt
    exitcode = self._kill_process(multiprocessing.Process.interrupt)
  File "/home/stan/buildarea/3.x.stan-raspbian.nondebug/build/Lib/contextlib.py", line 85, in inner
    return func(*args, **kwds)
  File "/home/stan/buildarea/3.x.stan-raspbian.nondebug/build/Lib/test/_test_multiprocessing.py", line 577, in _kill_process
    self.assertEqual(join(), None)
                     ~~~~^^
  File "/home/stan/buildarea/3.x.stan-raspbian.nondebug/build/Lib/test/_test_multiprocessing.py", line 250, in __call__
    return self.func(*args, **kwds)
           ~~~~~~~~~^^^^^^^^^^^^^^^
  File "/home/stan/buildarea/3.x.stan-raspbian.nondebug/build/Lib/multiprocessing/process.py", line 156, in join
    res = self._popen.wait(timeout)
  File "/home/stan/buildarea/3.x.stan-raspbian.nondebug/build/Lib/multiprocessing/popen_fork.py", line 44, in wait
    return self.poll(os.WNOHANG if timeout == 0.0 else 0)
           ~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/stan/buildarea/3.x.stan-raspbian.nondebug/build/Lib/multiprocessing/popen_fork.py", line 28, in poll
    pid, sts = os.waitpid(self.pid, flag)
               ~~~~~~~~~~^^^^^^^^^^^^^^^^
  File "/home/stan/buildarea/3.x.stan-raspbian.nondebug/build/Lib/test/_test_multiprocessing.py", line 573, in handler
    raise RuntimeError('join took too long: %s' % p)
RuntimeError: join took too long: <Process name='Process-1' pid=226230 parent=226228 started daemon>


Traceback (most recent call last):
  File "/home/stan/buildarea/3.x.stan-raspbian.nondebug/build/Lib/contextlib.py", line 85, in inner
    return func(*args, **kwds)
  File "/home/stan/buildarea/3.x.stan-raspbian.nondebug/build/Lib/test/_test_multiprocessing.py", line 596, in test_interrupt
    exitcode = self._kill_process(multiprocessing.Process.interrupt)
  File "/home/stan/buildarea/3.x.stan-raspbian.nondebug/build/Lib/contextlib.py", line 85, in inner
    return func(*args, **kwds)
  File "/home/stan/buildarea/3.x.stan-raspbian.nondebug/build/Lib/test/_test_multiprocessing.py", line 577, in _kill_process
    self.assertEqual(join(), None)
                     ~~~~^^
  File "/home/stan/buildarea/3.x.stan-raspbian.nondebug/build/Lib/test/_test_multiprocessing.py", line 250, in __call__
    return self.func(*args, **kwds)
           ~~~~~~~~~^^^^^^^^^^^^^^^
  File "/home/stan/buildarea/3.x.stan-raspbian.nondebug/build/Lib/multiprocessing/process.py", line 156, in join
    res = self._popen.wait(timeout)
  File "/home/stan/buildarea/3.x.stan-raspbian.nondebug/build/Lib/multiprocessing/popen_fork.py", line 44, in wait
    return self.poll(os.WNOHANG if timeout == 0.0 else 0)
           ~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/stan/buildarea/3.x.stan-raspbian.nondebug/build/Lib/multiprocessing/popen_fork.py", line 28, in poll
    pid, sts = os.waitpid(self.pid, flag)
               ~~~~~~~~~~^^^^^^^^^^^^^^^^
  File "/home/stan/buildarea/3.x.stan-raspbian.nondebug/build/Lib/test/_test_multiprocessing.py", line 573, in handler
    raise RuntimeError('join took too long: %s' % p)
RuntimeError: join took too long: <Process name='Process-151' pid=210285 parent=209827 started daemon>

pythonGH-133662) Remove deprecated `zipimport.zipimporter.load_module`.

Remove deprecated zipimport.zipimporter.load_module

7a33c7a

Wulian233 requested review from brettcannon, ericsnowcurrently, ncoghlan and warsaw as code owners May 8, 2025 12:54

bedevere-app Bot mentioned this pull request May 8, 2025

Remove deprecated zipimport.zipimporter.load_module #133656

Closed

bedevere-app Bot added the awaiting review label May 8, 2025

StanFromIreland reviewed May 8, 2025

View reviewed changes

Comment thread Doc/whatsnew/3.15.rst Outdated

StanFromIreland reviewed May 8, 2025

View reviewed changes

Comment thread Doc/deprecations/pending-removal-in-3.15.rst

Fix test failure

02919a6

sharktide reviewed May 10, 2025

View reviewed changes

Wulian233 added 6 commits May 11, 2025 20:18

Merge branch 'main' into zipimporter

f95d624

Update pending-removal-in-3.15.rst

ead7345

Update pending-removal-in-3.15.rst

963343d

Merge branch 'main' into zipimporter

91afdcb

Update 3.15.rst

0edaa29

Resolved conflict

5616e27

ncoghlan requested changes Aug 2, 2025

View reviewed changes

Comment thread Lib/test/test_zipimport.py Outdated

Comment thread Lib/test/test_zipimport.py Outdated

bedevere-app Bot added awaiting changes and removed awaiting review labels Aug 2, 2025

Wulian233 requested a review from ncoghlan August 11, 2025 02:03

move to before the first full import request

6207b71

Wulian233 requested a review from AA-Turner as a code owner August 11, 2025 13:16

bedevere-app Bot removed the awaiting changes label Aug 11, 2025

bedevere-app Bot added the awaiting change review label Aug 11, 2025

Merge branch 'main' into zipimporter

51373ed

gpshead approved these changes Aug 30, 2025

View reviewed changes

bedevere-app Bot added awaiting merge and removed awaiting change review labels Aug 30, 2025

gpshead enabled auto-merge (squash) August 30, 2025 01:08

gpshead merged commit 5c6937a into python:main Aug 30, 2025

bedevere-app Bot removed the awaiting merge label Aug 30, 2025

lkollar pushed a commit to lkollar/cpython that referenced this pull request Sep 9, 2025

pythongh-133656 : Remove deprecated zipimport.zipimporter.load_module (

1ab4544

pythonGH-133662) Remove deprecated `zipimport.zipimporter.load_module`.

Wulian233 deleted the zipimporter branch September 27, 2025 23:41

gh-133656: Remove deprecated `zipimport.zipimporter.load_module` by Wulian233 · Pull Request #133662 · python/cpython · GitHub

Repository navigation

gh-133656: Remove deprecated zipimport.zipimporter.load_module - #133662

gh-133656: Remove deprecated zipimport.zipimporter.load_module#133662gpshead merged 10 commits intopython:mainpython/cpython:mainfrom Wulian233:zipimporterWulian233/cpython:zipimporterCopy head branch name to clipboard

Conversation

Wulian233 commented May 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sharktide commented May 8, 2025

Uh oh!

Uh oh!

Uh oh!

sharktide commented May 10, 2025

Uh oh!

sharktide left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ncoghlan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

bedevere-app Bot commented Aug 2, 2025

Uh oh!

Wulian233 commented Aug 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ncoghlan commented Aug 11, 2025

Uh oh!

Wulian233 commented Aug 11, 2025

Uh oh!

bedevere-app Bot commented Aug 11, 2025

Uh oh!

bedevere-bot commented Aug 30, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

gh-133656: Remove deprecated zipimport.zipimporter.load_module#133662
gpshead merged 10 commits into
python:mainfrom
Wulian233:zipimporter

Wulian233 commented May 8, 2025 •
edited
Loading

sharktide left a comment •
edited
Loading

Wulian233 commented Aug 3, 2025 •
edited
Loading