gh-132983: Make zstd types immutable - #133784
Merged
AA-Turner merged 3 commits intoMay 10, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
13 tasks
picnixz
reviewed
May 9, 2025
Comment thread
Modules/_zstd/_zstdmodule.c
serhiy-storchaka
approved these changes
May 10, 2025
emmatyping
approved these changes
May 10, 2025
AA-Turner
enabled auto-merge (squash)
May 10, 2025 22:12
Copy link
Copy Markdown
|
Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 10, 2025
(cherry picked from commit 1a87b6e) Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Copy link
Copy Markdown
|
GH-133857 is a backport of this pull request to the 3.14 branch. |
Sorry, something went wrong.
AA-Turner
added a commit
that referenced
this pull request
May 10, 2025
Pranjal095
pushed a commit
to Pranjal095/cpython
that referenced
this pull request
Jul 12, 2025
taegyunkim
pushed a commit
to taegyunkim/cpython
that referenced
this pull request
Aug 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I haven't added tests as the other modules don't seem to have any for immutable types, but happy to do so if wanted.
A