FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

GH-132983: PEP 7 and Argument Clinic changes for zstd by AA-Turner · Pull Request #133791 · python/cpython · GitHub

/ cpython Public

GH-132983: PEP 7 and Argument Clinic changes for zstd - #133791

Merged
AA-Turner merged 4 commits into
python:mainfrom
AA-Turner:zstd-clinic
May 10, 2025
ConversationCommits (4)ChecksFiles changed
Merged

GH-132983: PEP 7 and Argument Clinic changes for zstd#133791
AA-Turner merged 4 commits into
python:mainfrom
AA-Turner:zstd-clinic

Conversation

AA-Turner commented May 9, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member
  • Remove leading underscore from module-level functions
  • Fix __module__ for zstd types implemented in C
  • PEP 7 style conformance
  • Make more things static

AA-Turner requested review from emmatyping and picnixz May 9, 2025 23:33
AA-Turner added skip news needs backport to 3.14 bugs and security fixes labels May 9, 2025
bedevere-app Bot mentioned this pull request May 9, 2025
Closed
13 tasks
emmatyping approved these changes May 10, 2025
View reviewed changes

emmatyping left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This looks great. Once it's landed I will go through and refactor the code to use more idiomatic locking patterns.

AA-Turner enabled auto-merge (squash) May 10, 2025 00:17
AA-Turner merged commit 1978904 into python:main May 10, 2025

miss-islington-app Bot commented May 10, 2025

Copy link
Copy Markdown

Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 10, 2025
pythonGH-132983: PEP 7 and Argument Clinic changes for zstd (pythonGH…
807082d 
…-133791)

(cherry picked from commit 1978904)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>

bedevere-app Bot commented May 10, 2025

Copy link
Copy Markdown

GH-133792 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label May 10, 2025
AA-Turner deleted the zstd-clinic branch May 10, 2025 00:34
AA-Turner added a commit that referenced this pull request May 10, 2025
[3.14] GH-132983: PEP 7 and Argument Clinic changes for zstd (GH-133791…
d9571c9 
…) (#133792)

GH-132983: PEP 7 and Argument Clinic changes for zstd (GH-133791)
(cherry picked from commit 1978904)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
pythonGH-132983: PEP 7 and Argument Clinic changes for zstd (python#1…
28b2101 
…33791)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
pythonGH-132983: PEP 7 and Argument Clinic changes for zstd (python#1…
f5d50ae 
…33791)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

emmatyping emmatyping approved these changes
picnixz Awaiting requested review from picnixz

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL