FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-132983: Reduce the size of `_zstdmodule.h` by AA-Turner · Pull Request #133793 · python/cpython · GitHub

/ cpython Public

gh-132983: Reduce the size of _zstdmodule.h - #133793

Merged
AA-Turner merged 10 commits into
python:mainfrom
AA-Turner:zstd-headers
May 10, 2025
ConversationCommits (10)ChecksFiles changed
Merged

gh-132983: Reduce the size of _zstdmodule.h#133793
AA-Turner merged 10 commits into
python:mainfrom
AA-Turner:zstd-headers

Conversation

AA-Turner commented May 10, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

We should try and reduce the content in the header file, as it is exposed to anything that includes it.

  • mt_continue_should_break() moves into compressor.c
  • The decompress_type enum moves into decompressor.c
  • Replace #pragma once (not used for any other modules or non-vendored code) with guard defines
  • Use angle-bracket includes for z{std,dict}.h
  • Add a zstddict.h header file to contain the definition of the ZstdDict struct
  • Move the ZstdCompressor struct to compressor.c (likewise for decompressor)
  • Make PyModuleDef _zstdmodule static

A

AA-Turner requested review from emmatyping and picnixz May 10, 2025 00:42
AA-Turner requested review from a team and erlend-aasland as code owners May 10, 2025 00:42
AA-Turner added skip news needs backport to 3.14 bugs and security fixes labels May 10, 2025
bedevere-app Bot mentioned this pull request May 10, 2025
Closed
13 tasks
AA-Turner removed request for a team and erlend-aasland May 10, 2025 00:42
emmatyping reviewed May 10, 2025
View reviewed changes
Comment thread Modules/_zstd/_zstdmodule.h
hugovk changed the title GH-132983: Reduce the size of _zstdmodule.h gh-132983: Reduce the size of _zstdmodule.h May 10, 2025

hugovk commented May 10, 2025

Copy link
Copy Markdown
Member

Nit note about PR titles, the convention is lowercase gh-NNN for issues, and uppercase GH-NNN for PRs:

please make sure to reference the issue number using gh-NNNNN: prefix in the pull request title

https://devguide.python.org/getting-started/pull-request-lifecycle/#submitting

[3.9] gh-12345: Fix the Spam Module (GH-NNNN)

Here gh-12345 is the GitHub issue number, and GH-NNNN is the number of the original pull request.

https://devguide.python.org/core-developers/committing/#backporting-changes-to-an-older-version

picnixz reviewed May 10, 2025
View reviewed changes
Comment thread Modules/_zstd/_zstdmodule.c
Comment thread Modules/_zstd/_zstdmodule.h
Comment thread Modules/_zstd/_zstdmodule.h Outdated
Comment thread Modules/_zstd/buffer.h
Comment thread Modules/_zstd/compressor.c Outdated
picnixz approved these changes May 10, 2025
View reviewed changes

picnixz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It's fun that the diff for reducing the size is +165/-164.

AA-Turner merged commit 1a548c0 into python:main May 10, 2025

miss-islington-app Bot commented May 10, 2025

Copy link
Copy Markdown

Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 10, 2025
pythongh-132983: Reduce the size of _zstdmodule.h (pythonGH-133793)
f29ced5 
(cherry picked from commit 1a548c0)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>

bedevere-app Bot commented May 10, 2025

Copy link
Copy Markdown

GH-133854 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label May 10, 2025
AA-Turner deleted the zstd-headers branch May 10, 2025 21:48
AA-Turner added a commit that referenced this pull request May 10, 2025
[3.14] gh-132983: Reduce the size of _zstdmodule.h (GH-133793) (#…
f7c441c 
…133854)

gh-132983: Reduce the size of ``_zstdmodule.h`` (GH-133793)
(cherry picked from commit 1a548c0)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
pythongh-132983: Reduce the size of _zstdmodule.h (python#133793)
4b09e0b
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
pythongh-132983: Reduce the size of _zstdmodule.h (python#133793)
527768f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

emmatyping emmatyping approved these changes
picnixz picnixz approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL