FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-133653: Fix argparse.ArgumentParser with the formatter_class argument by serhiy-storchaka · Pull Request #133813 · python/cpython · GitHub

/ cpython Public

gh-133653: Fix argparse.ArgumentParser with the formatter_class argument - #133813

Merged
serhiy-storchaka merged 2 commits into
python:mainfrom
serhiy-storchaka:argparse-custom-formatter
May 12, 2025
ConversationCommits (2)ChecksFiles changed
Merged

gh-133653: Fix argparse.ArgumentParser with the formatter_class argument#133813
serhiy-storchaka merged 2 commits into
python:mainfrom
serhiy-storchaka:argparse-custom-formatter

Conversation

serhiy-storchaka commented May 10, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member
  • Fix TypeError when formatter_class is a custom subclass of HelpFormatter.
  • Fix TypeError when formatter_class is not a subclass of HelpFormatter and non-standard prefix_char is used.
  • Fix support of colorizing when formatter_class is not a subclass of HelpFormatter.

pythongh-133653: Fix argparse.ArgumentParser with the formatter_class…
ef5d142 
… argument

* Fix TypeError when formatter_class is a custom subclass of
  HelpFormatter.
* Fix TypeError when formatter_class is not a subclass of
  HelpFormatter and non-standard prefix_char is used.
* Fix support of colorizing when formatter_class is not a subclass of
  HelpFormatter.
serhiy-storchaka added the needs backport to 3.14 bugs and security fixes label May 10, 2025
bedevere-app Bot mentioned this pull request May 10, 2025
Closed
serhiy-storchaka requested a review from hugovk May 10, 2025 09:49
serhiy-storchaka mentioned this pull request May 10, 2025
Closed
hugovk approved these changes May 10, 2025
View reviewed changes

hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks!

gentoo-bot pushed a commit to gentoo/gentoo that referenced this pull request May 11, 2025
dev-python/pygments: enable py3.14
92d1c6b 
Skip the help tests for now. Not ideal but it's not too bad and it's
not pygments-specific anyway.

Bug: python/cpython#133653
Bug: python/cpython#133813
Signed-off-by: Sam James <sam@gentoo.org>
tanuki-no pushed a commit to tanuki-no/gentoo that referenced this pull request May 12, 2025
dev-python/pygments: enable py3.14
b73bf53 
Skip the help tests for now. Not ideal but it's not too bad and it's
not pygments-specific anyway.

Bug: python/cpython#133653
Bug: python/cpython#133813
Signed-off-by: Sam James <sam@gentoo.org>
edgarrmondragon mentioned this pull request May 12, 2025
Merged
serhiy-storchaka merged commit 734e15b into python:main May 12, 2025

miss-islington-app Bot commented May 12, 2025

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

serhiy-storchaka deleted the argparse-custom-formatter branch May 12, 2025 17:27
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 12, 2025
pythongh-133653: Fix argparse.ArgumentParser with the formatter_class…
74c8bce 
… argument (pythonGH-133813)

* Fix TypeError when formatter_class is a custom subclass of
  HelpFormatter.
* Fix TypeError when formatter_class is not a subclass of
  HelpFormatter and non-standard prefix_char is used.
* Fix support of colorizing when formatter_class is not a subclass of
  HelpFormatter.
* Remove the prefix_chars parameter of HelpFormatter.
(cherry picked from commit 734e15b)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

bedevere-app Bot commented May 12, 2025

Copy link
Copy Markdown

GH-133941 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label May 12, 2025
serhiy-storchaka added a commit that referenced this pull request May 12, 2025
[3.14] gh-133653: Fix argparse.ArgumentParser with the formatter_clas…
c15980b 
…s argument (GH-133813) (GH-133941)

* Fix TypeError when formatter_class is a custom subclass of
  HelpFormatter.
* Fix TypeError when formatter_class is not a subclass of
  HelpFormatter and non-standard prefix_char is used.
* Fix support of colorizing when formatter_class is not a subclass of
  HelpFormatter.
* Remove the prefix_chars parameter of HelpFormatter.
(cherry picked from commit 734e15b)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
pythongh-133653: Fix argparse.ArgumentParser with the formatter_class…
b966a9e 
… argument (pythonGH-133813)

* Fix TypeError when formatter_class is a custom subclass of
  HelpFormatter.
* Fix TypeError when formatter_class is not a subclass of
  HelpFormatter and non-standard prefix_char is used.
* Fix support of colorizing when formatter_class is not a subclass of
  HelpFormatter.
* Remove the prefix_chars parameter of HelpFormatter.
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
pythongh-133653: Fix argparse.ArgumentParser with the formatter_class…
c171c58 
… argument (pythonGH-133813)

* Fix TypeError when formatter_class is a custom subclass of
  HelpFormatter.
* Fix TypeError when formatter_class is not a subclass of
  HelpFormatter and non-standard prefix_char is used.
* Fix support of colorizing when formatter_class is not a subclass of
  HelpFormatter.
* Remove the prefix_chars parameter of HelpFormatter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

hugovk hugovk approved these changes
savannahostrowski Awaiting requested review from savannahostrowski savannahostrowski is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL