FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-77065: Add argument `echo_char` for `getpass.fallback_getpass` by donbarbos · Pull Request #133849 · python/cpython · GitHub

/ cpython Public

gh-77065: Add argument echo_char for getpass.fallback_getpass - #133849

Merged
picnixz merged 2 commits into
python:mainfrom
donbarbos:issue-77065-fallback
May 15, 2025
ConversationCommits (2)ChecksFiles changed
Merged

gh-77065: Add argument echo_char for getpass.fallback_getpass#133849
picnixz merged 2 commits into
python:mainfrom
donbarbos:issue-77065-fallback

Conversation

donbarbos commented May 10, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

bedevere-app Bot mentioned this pull request May 10, 2025
Closed

donbarbos commented May 11, 2025

Copy link
Copy Markdown
Contributor Author

cc @JelleZijlstra @picnixz

picnixz reviewed May 11, 2025
View reviewed changes
Comment thread Lib/getpass.py
picnixz added skip news needs backport to 3.14 bugs and security fixes labels May 11, 2025

donbarbos commented May 15, 2025

Copy link
Copy Markdown
Contributor Author

should we ping someone else?

picnixz commented May 15, 2025

Copy link
Copy Markdown
Member

No, I was just away :')

picnixz merged commit d029a1a into python:main May 15, 2025

miss-islington-app Bot commented May 15, 2025

Copy link
Copy Markdown

Thanks @donbarbos for the PR, and @picnixz for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 15, 2025
pythongh-77065: add missing parameter echo_char in `getpass.fallbac…
f9d493b 
…k_getpass` (pythonGH-133849)

(cherry picked from commit d029a1a)

Co-authored-by: Semyon Moroz <donbarbos@proton.me>

bedevere-app Bot commented May 15, 2025

Copy link
Copy Markdown

GH-134053 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label May 15, 2025
picnixz pushed a commit that referenced this pull request May 15, 2025
[3.14] gh-77065: add missing parameter echo_char in `getpass.fallba…
29d69e8 
…ck_getpass` (GH-133849) (#134053)

gh-77065: add missing parameter `echo_char` in `getpass.fallback_getpass` (GH-133849)
(cherry picked from commit d029a1a)

Co-authored-by: Semyon Moroz <donbarbos@proton.me>

bedevere-bot commented May 15, 2025

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot iOS ARM64 Simulator 3.14 (tier-3) has failed when building commit 29d69e8.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1722/builds/74) and take a look at the build logs.
  4. Check if the failure is related to this commit (29d69e8) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1722/builds/74

Summary of the results of the build (if available):

Click to see traceback logs 
remote: Enumerating objects: 4, done.        
remote: Counting objects:  25% (1/4)        
remote: Counting objects:  50% (2/4)        
remote: Counting objects:  75% (3/4)        
remote: Counting objects: 100% (4/4)        
remote: Counting objects: 100% (4/4), done.        
remote: Compressing objects:  50% (1/2)        
remote: Compressing objects: 100% (2/2)        
remote: Compressing objects: 100% (2/2), done.        
remote: Total 4 (delta 2), reused 2 (delta 2), pack-reused 0 (from 0)        
From https://github.com/python/cpython
 * branch                    3.14       -> FETCH_HEAD
Note: switching to '29d69e8b661e5d4d270f44c03a2c678cc3ebc58d'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 29d69e8b661 [3.14] gh-77065: add missing parameter `echo_char` in `getpass.fallback_getpass` (GH-133849) (#134053)
Switched to and reset branch '3.14'

configure: WARNING: no system libmpdecimal found; falling back to bundled libmpdecimal (deprecated and scheduled for removal in Python 3.15)
configure: WARNING: pkg-config is missing. Some dependencies may not be detected correctly.

configure: WARNING: no system libmpdecimal found; falling back to bundled libmpdecimal (deprecated and scheduled for removal in Python 3.15)
configure: WARNING: pkg-config is missing. Some dependencies may not be detected correctly.

make: *** [testios] Terminated: 15

Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
pythongh-77065: add missing parameter echo_char in `getpass.fallbac…
036d409 
…k_getpass` (python#133849)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
pythongh-77065: add missing parameter echo_char in `getpass.fallbac…
5fa0016 
…k_getpass` (python#133849)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

JelleZijlstra JelleZijlstra approved these changes
picnixz picnixz approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL