gh-132983: Remove EndlessZstdDecompressor remains - #133856
Merged
AA-Turner merged 4 commits intoMay 11, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
13 tasks
AA-Turner
reviewed
May 10, 2025
Comment thread
Modules/_zstd/decompressor.c
Outdated
Comment thread
Modules/_zstd/decompressor.c
Outdated
Comment thread
Modules/_zstd/decompressor.c
Outdated
Comment thread
Modules/_zstd/decompressor.c
Outdated
Comment thread
Modules/_zstd/decompressor.c
Outdated
Comment thread
Modules/_zstd/decompressor.c
Outdated
Comment thread
Modules/_zstd/decompressor.c
Comment thread
Modules/_zstd/decompressor.c
Outdated
AA-Turner
reviewed
May 10, 2025
Comment thread
Modules/_zstd/decompressor.c
Outdated
Comment thread
Modules/_zstd/decompressor.c
Outdated
AA-Turner
approved these changes
May 10, 2025
AA-Turner
enabled auto-merge (squash)
May 11, 2025 01:38
Copy link
Copy Markdown
|
Thanks @Rogdham for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 11, 2025
…nGH-133856) (cherry picked from commit 878e0fb) Co-authored-by: Rogdham <3994389+Rogdham@users.noreply.github.com> Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com> Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Copy link
Copy Markdown
|
GH-133859 is a backport of this pull request to the 3.14 branch. |
Sorry, something went wrong.
AA-Turner
added a commit
that referenced
this pull request
May 11, 2025
…33856) (#133859) gh-132983: Remove leftovers from EndlessZstdDecompressor (GH-133856) (cherry picked from commit 878e0fb) Co-authored-by: Rogdham <3994389+Rogdham@users.noreply.github.com> Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com> Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Pranjal095
pushed a commit
to Pranjal095/cpython
that referenced
this pull request
Jul 12, 2025
…n#133856) Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com> Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
taegyunkim
pushed a commit
to taegyunkim/cpython
that referenced
this pull request
Aug 4, 2025
…n#133856) Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com> Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @emmatyping @AA-Turner (can't request review)
In pyzstd there was an EndlessZstdDecompressor class implemented in the C module. Some remains of the code were left, this PR aims to remove them.
In the comments, <D> refers to ZstdDecompressor whereas <E> refers to EndlessZstdDecompressor. I cleaned that up as well.
There was _unused_char_for_align in the ZstdDecompressor struct. My understanding is that it was placed only for optimization in decompressor_reset_session when setting several attributes to 0 at once. I removed it here, but if needed I can re-add it (twice to compensate the removal of at_frame_edge).