FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-133866: remove deprecated and undocumented function `ctypes.SetPointerType` by picnixz · Pull Request #133869 · python/cpython · GitHub

/ cpython Public

gh-133866: remove deprecated and undocumented function ctypes.SetPointerType - #133869

Merged
encukou merged 10 commits into
python:mainfrom
picnixz:cleanup/315/ctypes-set-pointer-type-133866
May 29, 2025
Merged

gh-133866: remove deprecated and undocumented function ctypes.SetPointerType#133869
encukou merged 10 commits into
python:mainfrom
picnixz:cleanup/315/ctypes-set-pointer-type-133866

Conversation

picnixz commented May 11, 2025
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

picnixz commented May 11, 2025

Copy link
Copy Markdown
Member Author

Let's discuss on the issue if we can also remove the C interface as Kumar wanted.

Comment thread Doc/whatsnew/3.15.rst Outdated

encukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Could you also remove the note from Doc/deprecations/pending-removal-in-3.15.rst?

Comment thread Doc/whatsnew/3.15.rst Outdated

picnixz commented May 15, 2025
edited
Loading

Copy link
Copy Markdown
Member Author

Could you also remove the note from Doc/deprecations/pending-removal-in-3.15.rst?

Are the docs for 3.14 served from the main branch or the 3.14 branch? if it's from the main branch, we need to preserve the file.

Note: I think we cannot delete them because they are built from the main branch.

Co-authored-by: Petr Viktorin <encukou@gmail.com>
Comment thread Doc/whatsnew/3.15.rst Outdated
picnixz requested a review from encukou May 20, 2025 10:56

encukou commented May 29, 2025

Copy link
Copy Markdown
Member

3.14 docs are built from the 3.14 branch. There are also 3.15 (dev) docs, though I see they don't yet always appear in the switcher.
Anyway, pending-removal-in-3.15.rst also lists some other API that's already gone; it'll need another cleanup pass.

Thank you for removing this!

encukou merged commit cafbcd6 into python:main May 29, 2025

mhsmith commented May 29, 2025

Copy link
Copy Markdown
Member

This PR appears to have broken the Lint check on the main branch: https://github.com/python/cpython/actions/runs/15324974930.

encukou commented May 30, 2025

Copy link
Copy Markdown
Member

Indeed, a lint check was quietly added while this was on review.

Anyway, Victor fixed it before I got to your comment :)

picnixz deleted the cleanup/315/ctypes-set-pointer-type-133866 branch May 30, 2025 13:52
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
gostak-dd pushed a commit to gostak-dd/cpython that referenced this pull request Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL