FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-133604: remove deprecated `java_ver` function by makridenko · Pull Request #133888 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-133604: remove deprecated java_ver function - #133888

Merged
malemburg merged 14 commits into
python:mainfrom
makridenko:fix-issue-133604
May 16, 2025
ConversationCommits (14)ChecksFiles changed
Merged

gh-133604: remove deprecated java_ver function#133888
malemburg merged 14 commits into
python:mainfrom
makridenko:fix-issue-133604

Conversation

makridenko commented May 11, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

python-cla-bot Bot commented May 11, 2025 •
edited
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

bedevere-app Bot commented May 11, 2025

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

bedevere-app Bot mentioned this pull request May 11, 2025
Closed
eendebakpt reviewed May 11, 2025
View reviewed changes
Comment thread Doc/whatsnew/3.13.rst
eendebakpt reviewed May 11, 2025
View reviewed changes
Comment thread Doc/whatsnew/3.15.rst Outdated
StanFromIreland reviewed May 11, 2025
View reviewed changes
Comment thread Doc/whatsnew/3.15.rst Outdated
platform
--------

* The deprecated :func:`!platform.java_ver` function.

StanFromIreland May 11, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
* The deprecated :func:`!platform.java_ver` function.
* Removed the deprecated :func:`!platform.java_ver` function.

To save Benedikt copy-editing it later. (See line 133)

You can also link this pr. (See line 134 as an example)

makridenko May 13, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@StanFromIreland thank you! done

Comment thread Lib/platform.py Outdated
#
# <see CVS and SVN checkin messages for history>
#
# 1.1.0 - removed deprecated java_ver()

StanFromIreland May 11, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Not noteworthy enough IMO. These are rarely updated, but it is up to @malemburg in the end.

malemburg May 12, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

No need to add to that list anymore. The checkin messages provide enough history.

malemburg May 12, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

You may want to change # <see CVS and SVN checkin messages for history> to # <see checkin messages for history>

makridenko May 13, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@malemburg thank you! done

picnixz reviewed May 16, 2025
View reviewed changes
Comment thread Doc/whatsnew/3.15.rst Outdated
Comment on lines +127 to +128
* Removed the deprecated :func:`!platform.java_ver` function.
(Contributed by Alexey Makridenko in :gh:`133888`.)

picnixz May 16, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
* Removed the deprecated :func:`!platform.java_ver` function.
(Contributed by Alexey Makridenko in :gh:`133888`.)
* Removed the :func:`!platform.java_ver` function,
which was deprecated since Python 3.13.
(Contributed by Alexey Makridenko in :gh:`133888`.)

The link should be the issue, not the PR.

makridenko May 16, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

thank you! fixed it

Comment thread Lib/platform.py
Comment thread Lib/platform.py
Comment thread Misc/NEWS.d/next/Library/2025-05-11-12-56-52.gh-issue-133604.kFxhc8.rst Outdated
@@ -0,0 +1 @@
Remove deprecated function :func:`!platform.java_ver`.

picnixz May 16, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
Remove deprecated function :func:`!platform.java_ver`.
Remove :func:`!platform.java_ver` which was deprecated since Python 3.13.

makridenko May 16, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

thank you! fixed it

makridenko requested a review from picnixz May 16, 2025 11:48
picnixz reviewed May 16, 2025
View reviewed changes

picnixz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Sorry to give you contradictory comments :') I didn't read the previous reviews, my bad!

Comment thread Doc/whatsnew/3.15.rst Outdated
picnixz reviewed May 16, 2025
View reviewed changes
Comment thread Doc/whatsnew/3.15.rst Outdated
malemburg approved these changes May 16, 2025
View reviewed changes

malemburg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, though I haven't actually run the test suite with these changes, or built the docs.

Note: The PR branch needs to be rebased before it can be merged.

malemburg commented May 16, 2025

Copy link
Copy Markdown
Member

Hmm, apparently, Github changed its mind about the need to rebase.

malemburg commented May 16, 2025

Copy link
Copy Markdown
Member

@StanFromIreland Do want to review again ? Otherwise, I'll merge the PR soon.

malemburg merged commit 7a4a6cf into python:main May 16, 2025

malemburg commented May 16, 2025

Copy link
Copy Markdown
Member

Thanks, @makridenko, for your work on this.

StanFromIreland commented May 16, 2025

Copy link
Copy Markdown
Member

Apologies I was unavailable.

picnixz mentioned this pull request Jun 14, 2025
Open
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
pythongh-133604: remove deprecated java_ver function (python#133888)
cfa5f13
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
pythongh-133604: remove deprecated java_ver function (python#133888)
fe85f53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

eendebakpt eendebakpt left review comments
picnixz picnixz approved these changes
malemburg malemburg approved these changes
StanFromIreland Awaiting requested review from StanFromIreland

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL