gh-132983: Fix zstd compiler warning about unused function mt_continue_should_break() - #133947
Merged
AA-Turner merged 1 commit intoMay 12, 2025
Merged
gh-132983: Fix zstd compiler warning about unused function mt_continue_should_break()#133947AA-Turner merged 1 commit into
AA-Turner merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…ontinue_should_break()
13 tasks
Copy link
Copy Markdown
Contributor
Author
|
AFAICS, mt_continue_should_break is only used in an assert, so we can safely only define it if we're debugging. |
Sorry, something went wrong.
emmatyping
approved these changes
May 12, 2025
AA-Turner
approved these changes
May 12, 2025
AA-Turner
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Sorry, I didn't see this compiler warning locally (do you need different flags for it?).
A
Sorry, something went wrong.
This comment was marked as outdated.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 12, 2025
…inue_should_break()`` (pythonGH-133947) (cherry picked from commit 121ed71) Co-authored-by: Erlend E. Aasland <erlend@python.org>
Copy link
Copy Markdown
|
GH-133950 is a backport of this pull request to the 3.14 branch. |
Sorry, something went wrong.
Pranjal095
pushed a commit
to Pranjal095/cpython
that referenced
this pull request
Jul 12, 2025
…inue_should_break()`` (python#133947)
taegyunkim
pushed a commit
to taegyunkim/cpython
that referenced
this pull request
Aug 4, 2025
…inue_should_break()`` (python#133947)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the following compiler warning:
./Modules/_zstd/compressor.c:490:1: warning: unused function 'mt_continue_should_break' [-Wunused-function] 490 | mt_continue_should_break(ZSTD_inBuffer *in, ZSTD_outBuffer *out) | ^~~~~~~~~~~~~~~~~~~~~~~~ 1 warning generated.