FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-132983: Call Py_XDECREF rather than PyObject_GC_Del in failed __new__ by encukou · Pull Request #133962 · python/cpython · GitHub

/ cpython Public

gh-132983: Call Py_XDECREF rather than PyObject_GC_Del in failed __new__ - #133962

Merged
encukou merged 1 commit into
python:mainfrom
encukou:zstd-new-refleak
May 13, 2025
ConversationCommits (1)ChecksFiles changed
Merged

gh-132983: Call Py_XDECREF rather than PyObject_GC_Del in failed __new__#133962
encukou merged 1 commit into
python:mainfrom
encukou:zstd-new-refleak

Conversation

encukou commented May 13, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

This will call tp_dealloc and clear all members.

Call Py_XDECREF rather than PyObject_GC_Del in failed __new__
abbdc96 
This will call tp_dealloc and clear all members.
bedevere-app Bot mentioned this pull request May 13, 2025
Closed
13 tasks
encukou requested a review from AA-Turner May 13, 2025 06:50
This was referenced May 13, 2025
Merged
Merged
serhiy-storchaka reviewed May 13, 2025
View reviewed changes

serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

See also https://github.com/python/cpython/pull/133924/files#r2084922874

There may be other similar errors in these files.

encukou commented May 13, 2025

Copy link
Copy Markdown
Member Author

I'll merge to fix the tier-1 buildbot; further fix-ups welcome.

encukou merged commit e575190 into python:main May 13, 2025
serhiy-storchaka added the needs backport to 3.14 bugs and security fixes label May 13, 2025

miss-islington-app Bot commented May 13, 2025

Copy link
Copy Markdown

Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington-app Bot commented May 13, 2025

Copy link
Copy Markdown

Sorry, @encukou, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker e575190abbd9409adad3e7fd95424f827236bed9 3.14

AA-Turner commented May 13, 2025

Copy link
Copy Markdown
Member

Thanks for the fix & merge @encukou -- backport will fail as the original commit isn't yet backported.

AA-Turner added needs backport to 3.14 bugs and security fixes and removed needs backport to 3.14 bugs and security fixes labels May 20, 2025

miss-islington-app Bot commented May 20, 2025

Copy link
Copy Markdown

Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 20, 2025
pythongh-132983: Call Py_XDECREF rather than PyObject_GC_Del in faile…
8216650 
…d __new__ (pythonGH-133962)

Call Py_XDECREF rather than PyObject_GC_Del in failed __new__

This will call tp_dealloc and clear all members.
(cherry picked from commit e575190)

Co-authored-by: Petr Viktorin <encukou@gmail.com>

bedevere-app Bot commented May 20, 2025

Copy link
Copy Markdown

GH-134305 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label May 20, 2025
AA-Turner pushed a commit that referenced this pull request May 20, 2025
[3.14] gh-132983: Call Py_XDECREF rather than PyObject_GC_Del in fail…
07a2033 
…ed __new__ (GH-133962) (#134305)

gh-132983: Call Py_XDECREF rather than PyObject_GC_Del in failed __new__ (GH-133962)

Call Py_XDECREF rather than PyObject_GC_Del in failed __new__

This will call tp_dealloc and clear all members.
(cherry picked from commit e575190)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
pythongh-132983: Call Py_XDECREF rather than PyObject_GC_Del in faile…
bcce301 
…d __new__ (pythonGH-133962)

Call Py_XDECREF rather than PyObject_GC_Del in failed __new__

This will call tp_dealloc and clear all members.
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
pythongh-132983: Call Py_XDECREF rather than PyObject_GC_Del in faile…
c184336 
…d __new__ (pythonGH-133962)

Call Py_XDECREF rather than PyObject_GC_Del in failed __new__

This will call tp_dealloc and clear all members.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

serhiy-storchaka serhiy-storchaka approved these changes
AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Assignees

encukou

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL