gh-77065: Use putwch instead of putch in win_getpass - #134058
Merged
picnixz merged 1 commit intoMay 15, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
I just got Windows today to run the tests, and only now figured out how to compile python and now I'm ashamed that we have to send patches for one PR |
Sorry, something went wrong.
picnixz
reviewed
May 15, 2025
Comment thread
Lib/getpass.py
picnixz
approved these changes
May 15, 2025
picnixz
enabled auto-merge (squash)
May 15, 2025 15:04
Copy link
Copy Markdown
|
Thanks @donbarbos for the PR, and @picnixz for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 15, 2025
…ss` (pythonGH-134058) (cherry picked from commit 52a7a22) Co-authored-by: Semyon Moroz <donbarbos@proton.me>
Copy link
Copy Markdown
|
GH-134059 is a backport of this pull request to the 3.14 branch. |
Sorry, something went wrong.
picnixz
pushed a commit
that referenced
this pull request
May 15, 2025
Pranjal095
pushed a commit
to Pranjal095/cpython
that referenced
this pull request
Jul 12, 2025
taegyunkim
pushed a commit
to taegyunkim/cpython
that referenced
this pull request
Aug 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @picnixz
based on #130496 (comment)