FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-69605: Disable PyREPL module autocomplete fallback on regular completion by loic-simon · Pull Request #134181 · python/cpython · GitHub

/ cpython Public

gh-69605: Disable PyREPL module autocomplete fallback on regular completion - #134181

Merged
ambv merged 7 commits into
python:mainfrom
loic-simon:pyrepl-module-completion-dont-fallback
May 25, 2025
ConversationCommits (7)ChecksFiles changed
Merged

gh-69605: Disable PyREPL module autocomplete fallback on regular completion#134181
ambv merged 7 commits into
python:mainfrom
loic-simon:pyrepl-module-completion-dont-fallback

Conversation

loic-simon commented May 18, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

When no module completions are available, do not fallback on completions from current namespace, as there are not relevant.

Before:

>>> import pri<TAB>
>>> import print(
>>>
>>> from typing import Na<TAB>
>>> from typing import NameError(

After:

>>> import pri<TAB>
>>> import pri
>>>
>>> from typing import Na<TAB>
>>> from typing import Na

cc @tomasr8

PyREPL module autocomplete: do not fallback
8978e95 
When no module completions are available, do not fallback to completions from current namespace

bedevere-app Bot commented May 18, 2025

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

bedevere-app Bot mentioned this pull request May 18, 2025
Closed
ZeroIntensity requested a review from tomasr8 May 18, 2025 14:34
tomasr8 reviewed May 18, 2025
View reviewed changes

tomasr8 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Nice! Overall approach looks good, I just have some nitpicks 🙂

Comment thread Lib/test/test_pyrepl/test_pyrepl.py Outdated
Comment thread Lib/_pyrepl/readline.py Outdated
Comment thread Misc/NEWS.d/next/Core_and_Builtins/2025-05-18-14-33-23.gh-issue-69605.ZMO49F.rst Outdated
tomasr8 approved these changes May 21, 2025
View reviewed changes

tomasr8 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM!

Comment thread Lib/_pyrepl/_module_completer.py Outdated
ambv merged commit 0e3bc96 into python:main May 25, 2025
ambv added the needs backport to 3.14 bugs and security fixes label May 25, 2025

miss-islington-app Bot commented May 25, 2025

Copy link
Copy Markdown

Thanks @loic-simon for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 25, 2025
pythongh-69605: Disable PyREPL module autocomplete fallback on regula…
75b216c 
…r completion (pythongh-134181)

(cherry picked from commit 0e3bc96)

Co-authored-by: Loïc Simon <loic.pano@gmail.com>
Co-authored-by: Loïc Simon <loic.simon@napta.io>

bedevere-app Bot commented May 25, 2025

Copy link
Copy Markdown

GH-134680 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label May 25, 2025
ambv pushed a commit that referenced this pull request May 25, 2025
[3.14] gh-69605: Disable PyREPL module autocomplete fallback on regul…
7216f7b 
…ar completion (gh-134181) (gh-134680)

(cherry picked from commit 0e3bc96)

Co-authored-by: Loïc Simon <loic.simon@napta.io>
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
pythongh-69605: Disable PyREPL module autocomplete fallback on regula…
1d9d573 
…r completion (pythongh-134181)

Co-authored-by: Loïc Simon <loic.simon@napta.io>
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
pythongh-69605: Disable PyREPL module autocomplete fallback on regula…
351817c 
…r completion (pythongh-134181)

Co-authored-by: Loïc Simon <loic.simon@napta.io>
loic-simon mentioned this pull request Aug 30, 2025
Merged
gostak-dd pushed a commit to gostak-dd/cpython that referenced this pull request Jun 2, 2026
pythongh-69605: Disable PyREPL module autocomplete fallback on regula…
eacca66 
…r completion (pythongh-134181)

Co-authored-by: Loïc Simon <loic.simon@napta.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

tomasr8 tomasr8 approved these changes
pablogsal Awaiting requested review from pablogsal pablogsal is a code owner
lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner
ambv Awaiting requested review from ambv ambv is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL