Repository navigation
gh-62184: Remove _pyio import of _io.FileIO - #134192
ambv merged 2 commits into
Conversation
Sorry, something went wrong.
This was added in the add of `_io`, isn't used since bpo-21859 when a `_pyio` implementation was added which defines `FileIO` lower down in the file.
AA-Turner
left a comment
There was a problem hiding this comment.
Can you add a test (maybe using the new helper) that _io isn't imported when importing _pyio?
A
Sorry, something went wrong.
|
_io is still imported indirectly (by way of io), so a test with new helper would fail currently I think? Can work on that, but I think splitting io.py into two parts (1. common base for _pyio and _io 2. forward/dispatch to _io) likely isn't worth the performance impact at the moment (see also changing from importing io to _io to increase performance in gh-132952). |
Sorry, something went wrong.
This was added in the add of `_io`, isn't used since bpo-21859 when a `_pyio` implementation was added which defines `FileIO` lower down in the file. (cherry picked from commit 0a68068) Co-authored-by: Cody Maloney <cmaloney@users.noreply.github.com>
This was added in the add of `_io`, isn't used since bpo-21859 when a `_pyio` implementation was added which defines `FileIO` lower down in the file. (cherry picked from commit 0a68068) Co-authored-by: Cody Maloney <cmaloney@users.noreply.github.com>
|
GH-134436 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
|
GH-134437 is a backport of this pull request to the 3.14 branch. |
Sorry, something went wrong.
This was added in the add of `_io`, isn't used since bpo-21859 when a `_pyio` implementation was added which defines `FileIO` lower down in the file.
This was added in the add of `_io`, isn't used since bpo-21859 when a `_pyio` implementation was added which defines `FileIO` lower down in the file.
This was added in the add of `_io`, isn't used since bpo-21859 when a `_pyio` implementation was added which defines `FileIO` lower down in the file.
This was added in the add of `_io`, isn't used since bpo-21859 when a `_pyio` implementation was added which defines `FileIO` lower down in the file.
This was added in the add of _io, isn't used since bpo-21859 added a Python-native _pyio implementation of FileIO further down in the file.
(Happy to add a news, but also don't think there is particularly a user visible change?)
This is the last direct import of _io in _pyio. _io is still imported indirectly (by way of io) for io.open_code, io.UnsupportedOperation, and registering _pyio base abstract classes to the general io ones for isinstance, and several constants (ex. SEEK_SET, ...).