FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-128307: Update docs for asyncio.create_task, TaskGroup.create_task, asyncio.create_task by graingert · Pull Request #134202 · python/cpython · GitHub

/ cpython Public

gh-128307: Update docs for asyncio.create_task, TaskGroup.create_task, asyncio.create_task - #134202

Merged
gvanrossum merged 6 commits into
python:mainfrom
graingert:doc-new-asyncio-create-task-kwargs
May 22, 2025
ConversationCommits (6)ChecksFiles changed
Merged

gh-128307: Update docs for asyncio.create_task, TaskGroup.create_task, asyncio.create_task#134202
gvanrossum merged 6 commits into
python:mainfrom
graingert:doc-new-asyncio-create-task-kwargs

Conversation

graingert commented May 19, 2025 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

bedevere-app Bot mentioned this pull request May 19, 2025
Closed
bedevere-app Bot added docs Documentation in the Doc dir skip news labels May 19, 2025
github-project-automation Bot moved this to Todo in Docs PRs May 19, 2025
graingert commented May 19, 2025
View reviewed changes
Comment thread Doc/library/asyncio-eventloop.rst Outdated
graingert commented May 19, 2025
View reviewed changes
Comment thread Doc/library/asyncio-eventloop.rst
graingert commented May 19, 2025
View reviewed changes
Comment thread Doc/library/asyncio-task.rst Outdated
gvanrossum mentioned this pull request May 20, 2025
Merged
graingert marked this pull request as ready for review May 20, 2025 06:54
gvanrossum reviewed May 20, 2025
View reviewed changes

gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM except I'm uneasy with how name, context and eager_task arguments are presented.

Comment thread Doc/library/asyncio-eventloop.rst

gvanrossum commented May 20, 2025

Copy link
Copy Markdown
Member

You're also going to backport these to 3.13 right? (But describing how 3.13.4 works -- you can't change 3.13.3 by definition).

graingert commented May 20, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

You're also going to backport these to 3.13 right? (But describing how 3.13.4 works -- you can't change 3.13.3 by definition).

I thought we were happy with the docs on 3.13 now? So this won't need a backport

gvanrossum commented May 20, 2025

Copy link
Copy Markdown
Member

I thought we were happy with the docs on 3.13 now? So this won't need a backport

Agreed, not to 3.13. But this should be marked as backport to 3.14 right?

What do you think about my comment on the signature description?

gvanrossum added the needs backport to 3.14 bugs and security fixes label May 20, 2025
gvanrossum approved these changes May 22, 2025
View reviewed changes

gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LG then! I will merge and ensure a backport to 3.14 happens.

gvanrossum changed the title gh-128307: update docs to TaskGroup.create_task and asyncio.create_task gh-128307: Update docs for asyncio.create_task, TaskGroup.create_task, asyncio.create_task May 22, 2025
gvanrossum merged commit a3d0306 into python:main May 22, 2025
github-project-automation Bot moved this from Todo to Done in Docs PRs May 22, 2025

miss-islington-app Bot commented May 22, 2025

Copy link
Copy Markdown

Thanks @graingert for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 22, 2025
pythongh-128307: Update docs for asyncio.create_task, TaskGroup.creat…
cd5c579 
…e_task, asyncio.create_task (pythonGH-134202)

(cherry picked from commit a3d0306)

Co-authored-by: Thomas Grainger <tagrain@gmail.com>

bedevere-app Bot commented May 22, 2025

Copy link
Copy Markdown

GH-134553 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label May 22, 2025
kumaraditya303 pushed a commit that referenced this pull request May 23, 2025
[3.14] gh-128307: Update docs for asyncio.create_task, TaskGroup.crea…
1cdbb33 
…te_task, asyncio.create_task (GH-134202) (#134553)

gh-128307: Update docs for asyncio.create_task, TaskGroup.create_task, asyncio.create_task (GH-134202)
(cherry picked from commit a3d0306)

Co-authored-by: Thomas Grainger <tagrain@gmail.com>
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
pythongh-128307: Update docs for asyncio.create_task, TaskGroup.creat…
2cfbdab 
…e_task, asyncio.create_task (python#134202)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
pythongh-128307: Update docs for asyncio.create_task, TaskGroup.creat…
c2dab71 
…e_task, asyncio.create_task (python#134202)
gostak-dd pushed a commit to gostak-dd/cpython that referenced this pull request Jun 2, 2026
pythongh-128307: Update docs for asyncio.create_task, TaskGroup.creat…
e7f23d0 
…e_task, asyncio.create_task (python#134202)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gvanrossum gvanrossum approved these changes
1st1 Awaiting requested review from 1st1 1st1 is a code owner
asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner
willingc Awaiting requested review from willingc willingc is a code owner

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL