FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-132983: Add zstd version info to `test.pythoninfo` by StanFromIreland · Pull Request #134230 · python/cpython · GitHub

/ cpython Public

gh-132983: Add zstd version info to test.pythoninfo - #134230

Merged
vstinner merged 6 commits into
python:mainfrom
StanFromIreland:zstd-ver
May 19, 2025
ConversationCommits (6)ChecksFiles changed
Merged

gh-132983: Add zstd version info to test.pythoninfo#134230
vstinner merged 6 commits into
python:mainfrom
StanFromIreland:zstd-ver

Conversation

StanFromIreland commented May 19, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

bedevere-app Bot mentioned this pull request May 19, 2025
Closed
13 tasks
vstinner approved these changes May 19, 2025
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. I have a minor PEP 8 remark. But the CI is failing.

Comment thread Lib/test/pythoninfo.py

vstinner commented May 19, 2025

Copy link
Copy Markdown
Member

Tests / Ubuntu / build and test (ubuntu-24.04) (pull_request)Failing after 3m

Unexpected warnings:
Include/opcode_ids.h expected 0 warnings, found 2
{'file': 'Include/opcode_ids.h', 'line': '132', 'column': '48', 'message': 'initialized field overwritten', 'option': '-Woverride-init'}
{'file': 'Include/opcode_ids.h', 'line': '133', 'column': '48', 'message': 'initialized field overwritten', 'option': '-Woverride-init'}

StanFromIreland commented May 19, 2025

Copy link
Copy Markdown
Member Author

Fails are unrelated from what I can tell, most should be resolved by updating the branch as pr's fixing have been merged.

Docs test will fail, but it is fine since #133911 will be merged soon enough.

StanFromIreland commented May 19, 2025

Copy link
Copy Markdown
Member Author

Yep, all [excluding expected fail] test pass.

vstinner commented May 19, 2025

Copy link
Copy Markdown
Member

I clicked on [Update branch] to try to repair the CI.

vstinner commented May 19, 2025

Copy link
Copy Markdown
Member

@StanFromIreland: There is an issue in the doc:

/home/runner/work/cpython/cpython/Doc/build/NEWS:74: WARNING: py:mod reference target not found: compression.zstd [ref.mod]

Update Misc/NEWS.d/next/Library/2025-05-19-15-30-00.gh-issue-132983.a…
4d38115 
…sdsfs.rst

Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner merged commit 46d7c11 into python:main May 19, 2025

vstinner commented May 19, 2025

Copy link
Copy Markdown
Member

Merged, thanks.

Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
pythongh-132983: Add zstd version info to test.pythoninfo (python#1…
7248a02 
…34230)

Co-authored-by: Victor Stinner <vstinner@python.org>
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
pythongh-132983: Add zstd version info to test.pythoninfo (python#1…
8f0d01f 
…34230)

Co-authored-by: Victor Stinner <vstinner@python.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner approved these changes
emmatyping emmatyping approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL