| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
Thanks for the PR. I'd like to advocate for this PR #132733 which will simplify this PR quite a bit. All you'd have to do after that PR lands is to add pure to the current bytecode definition. Then if you want you can improve the cases generator to automatically insert the pops. |
Sorry, something went wrong.
|
Ah, I didn't know that work was happening. I'll add some tests and then add the annotations when your PR lands. |
Sorry, something went wrong.
|
Thanks! The tests are definitely still gonna be very useful :). |
Sorry, something went wrong.
|
@savannahostrowski sorry for blocking this PR! The base PR has landed. You just have to replace the body in the optimizer_bytecodes.c with REPLACE_OPCODE_IF_EVALUATES_PURE(left, right) now. |
Sorry, something went wrong.
|
It’ll also involve modifying the cases generator to insert the new instruction when there is a single output and it’s immortal, too. |
Sorry, something went wrong.
|
We should also swap out _COMPARE_OP_INT to use the new style in this PR while we're at it I think. |
Sorry, something went wrong.
|
Closing this in favour of a different approach using the new machinery Ken Jin introduced for pure ops. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.