gh-134291: Add unguarded-availability check to JIT builds - #134292
Closed
zanieb wants to merge 3 commits into
Closed
gh-134291: Add unguarded-availability check to JIT builds#134292zanieb wants to merge 3 commits into
zanieb wants to merge 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Author
|
In https://github.com/python/cpython/actions/runs/15123945496/job/42512754979?pr=134292, you can see this fails "as intended" because a symbol requiring 11+ is used. This pull request will need to be merged after a guard is added for that symbol (or, its use is removed entirely). |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@brandtbucher were you still intending to fix use of that symbol? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Yes, sorry about the delay! I'll have it fixed hopefully this weekend. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.