FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

GH-130727: test_wmi_query_error test is flaky by chris-eibl · Pull Request #134313 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

GH-130727: test_wmi_query_error test is flaky - #134313

Merged
zooba merged 4 commits into
python:mainfrom
chris-eibl:fix_wmi_race
May 20, 2025
ConversationCommits (4)ChecksFiles changed
Merged

GH-130727: test_wmi_query_error test is flaky #134313
zooba merged 4 commits into
python:mainfrom
chris-eibl:fix_wmi_race

Conversation

chris-eibl commented May 20, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

I can reproduce the the "invalid handle" errors which @vstinner has also seen #130727 (comment) under high load (using "Stress CPU" of CPU-Z) running

python -m test test_wmi -m test.test_wmi.WmiTests.test_wmi_query_repeated -F

The reason is, that the main thread calls CloseHandle on the still running thread in case of a WAIT_TIMEOUT, and then the thread dies with

Exception thrown at 0x00007FFE1A35144A (ntdll.dll) in python_d.exe: 0xC0000008: An invalid handle was specified.

and call stack

 	ntdll.dll!00007ffe1a35144a()	Unknown
 	KernelBase.dll!00007ffe17cd0905()	Unknown
>	_wmi_d.pyd!_query_thread(void * param) Line 204	C++

where

    CloseHandle(data->writePipe); //Line 204
    return (DWORD)hr;

when I debug it in Visual Studio.

This has already been anticipated by @runn in #125315 (comment).

Another manifestation of this race results in

======================================================================
FAIL: test_wmi_query_repeated (test.test_wmi.WmiTests.test_wmi_query_repeated)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "R:\buildarea\3.14.ambv-bb-win11.bigmem\build\Lib\test\test_wmi.py", line 41, in test_wmi_query_repeated
    self.test_wmi_query_os_version()
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^
  File "R:\buildarea\3.14.ambv-bb-win11.bigmem\build\Lib\test\test_wmi.py", line 30, in test_wmi_query_os_version
    self.assertEqual(1, len(r))
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^
AssertionError: 1 != 2

which sometimes occur on the build bots, e.g. https://buildbot.python.org/#/builders/1799/builds/20.

Copying the _query_data struct in the wmi thread fixes both issues.

chris-eibl requested a review from a team as a code owner May 20, 2025 05:39
bedevere-app Bot mentioned this pull request May 20, 2025
Closed
chris-eibl requested a review from zooba May 20, 2025 05:40

chris-eibl commented May 20, 2025

Copy link
Copy Markdown
Member Author

@zooba: I am unsure whether to associate this PR with #130727 or #125315, I went with the former. In that case, I think it doesn't need a news entry, since it is just fixing a flaky test, but I'd happily blurb it if it deems appropriate.

zooba commented May 20, 2025

Copy link
Copy Markdown
Member

@chris-eibl Yeah, give it a NEWS entry, since it's a change to the runtime rather than the tests, and so users might see it out in the wild and wonder about the changed behaviour.

Before merging, I'd want to confirm that there's no intentional modification of that struct that is supposed to be picked up by the other thread. I suspect not, but I haven't read the code to double-check.

zooba merged commit e4fbfb1 into python:main May 20, 2025
zooba added needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes labels May 20, 2025

miss-islington-app Bot commented May 20, 2025

Copy link
Copy Markdown

Thanks @chris-eibl for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington-app Bot commented May 20, 2025

Copy link
Copy Markdown

Thanks @chris-eibl for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 20, 2025
pythonGH-130727: Avoid race condition in _wmimodule by copying shared…
24019bb 
… data (pythonGH-134313)

(cherry picked from commit e4fbfb1)

Co-authored-by: Chris Eibl <138194463+chris-eibl@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 20, 2025
pythonGH-130727: Avoid race condition in _wmimodule by copying shared…
ecab5f3 
… data (pythonGH-134313)

(cherry picked from commit e4fbfb1)

Co-authored-by: Chris Eibl <138194463+chris-eibl@users.noreply.github.com>

bedevere-app Bot commented May 20, 2025

Copy link
Copy Markdown

GH-134396 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 only security fixes label May 20, 2025

bedevere-app Bot commented May 20, 2025

Copy link
Copy Markdown

GH-134397 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label May 20, 2025
chris-eibl deleted the fix_wmi_race branch May 20, 2025 21:23
zooba pushed a commit that referenced this pull request May 20, 2025
GH-130727: Avoid race condition in _wmimodule by copying shared data (G…
35eb3b8 
…H-134313)

(cherry picked from commit e4fbfb1)

Co-authored-by: Chris Eibl <138194463+chris-eibl@users.noreply.github.com>
zooba pushed a commit that referenced this pull request May 20, 2025
GH-130727: Avoid race condition in _wmimodule by copying shared data (G…
81c348b 
…H-134313)

(cherry picked from commit e4fbfb1)

Co-authored-by: Chris Eibl <138194463+chris-eibl@users.noreply.github.com>
lkollar pushed a commit to lkollar/cpython that referenced this pull request May 26, 2025
pythonGH-130727: Avoid race condition in _wmimodule by copying shared…
9ae095a 
… data (pythonGH-134313)
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
pythonGH-130727: Avoid race condition in _wmimodule by copying shared…
4406589 
… data (pythonGH-134313)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
pythonGH-130727: Avoid race condition in _wmimodule by copying shared…
ecfe854 
… data (pythonGH-134313)
gostak-dd pushed a commit to gostak-dd/cpython that referenced this pull request Jun 2, 2026
pythonGH-130727: Avoid race condition in _wmimodule by copying shared…
a631b05 
… data (pythonGH-134313)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

zooba zooba left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL