FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-134360 Add processName attribute to `logging.Formatter` docstring by SofieTorch · Pull Request #134371 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-134360 Add processName attribute to logging.Formatter docstring - #134371

Merged
vsajip merged 1 commit into
python:mainfrom
SofieTorch:docs/formatter
May 21, 2025
ConversationCommits (1)ChecksFiles changed
Merged

gh-134360 Add processName attribute to logging.Formatter docstring#134371
vsajip merged 1 commit into
python:mainfrom
SofieTorch:docs/formatter

Conversation

SofieTorch commented May 20, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

As the issue #134360 suggests, the Formatter class was missing the processName attribute inside its docstring.

I've added the attribute to the docstring and made sure that it actually is in the LogRecord class. Now it is just as in the LogRecord attributes section of the Python documentation.

add processName attribute to logging.Formatter docstring
66fe1d2 
add processName to logging.Formatter docstring
SofieTorch requested a review from vsajip as a code owner May 20, 2025 17:58

python-cla-bot Bot commented May 20, 2025 •
edited
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

bedevere-app Bot commented May 20, 2025

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

bedevere-app Bot mentioned this pull request May 20, 2025
Closed
vsajip merged commit c740fe3 into python:main May 21, 2025
vsajip added needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes labels May 21, 2025

miss-islington-app Bot commented May 21, 2025

Copy link
Copy Markdown

Thanks @SofieTorch for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington-app Bot commented May 21, 2025

Copy link
Copy Markdown

Thanks @SofieTorch for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 21, 2025
pythongh-134360 Add processName attribute to logging.Formatter docs…
0ddcf8c 
…tring (pythonGH-134371)

(cherry picked from commit c740fe3)

Co-authored-by: Sofia Toro <sofie.torch@outlook.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 21, 2025
pythongh-134360 Add processName attribute to logging.Formatter docs…
8ab3d64 
…tring (pythonGH-134371)

(cherry picked from commit c740fe3)

Co-authored-by: Sofia Toro <sofie.torch@outlook.com>

bedevere-app Bot commented May 21, 2025

Copy link
Copy Markdown

GH-134404 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 only security fixes label May 21, 2025

bedevere-app Bot commented May 21, 2025

Copy link
Copy Markdown

GH-134405 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label May 21, 2025
vsajip pushed a commit that referenced this pull request May 21, 2025
[3.13] gh-134360 Add processName attribute to logging.Formatter doc…
7ada439 
…string (GH-134371) (GH-134404)

Co-authored-by: Sofia Toro <sofie.torch@outlook.com>
vsajip pushed a commit that referenced this pull request May 21, 2025
[3.14] gh-134360 Add processName attribute to logging.Formatter doc…
64047f7 
…string (GH-134371) (GH-134405)

Co-authored-by: Sofia Toro <sofie.torch@outlook.com>
lkollar pushed a commit to lkollar/cpython that referenced this pull request May 26, 2025
pythongh-134360 Add processName attribute to logging.Formatter docs…
77908ec 
…tring (pythonGH-134371)
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
pythongh-134360 Add processName attribute to logging.Formatter docs…
0bdb422 
…tring (pythonGH-134371)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
pythongh-134360 Add processName attribute to logging.Formatter docs…
04d2f13 
…tring (pythonGH-134371)
gostak-dd pushed a commit to gostak-dd/cpython that referenced this pull request Jun 2, 2026
pythongh-134360 Add processName attribute to logging.Formatter docs…
220525c 
…tring (pythonGH-134371)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vsajip vsajip approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL