FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Docs: Fix indentation in slice class of functions.rst by reynoldsnlp · Pull Request #134393 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

Docs: Fix indentation in slice class of functions.rst - #134393

Merged
ZeroIntensity merged 3 commits into
python:mainfrom
reynoldsnlp:patch-1
Jun 25, 2025
ConversationCommits (3)ChecksFiles changed
Merged

Docs: Fix indentation in slice class of functions.rst#134393
ZeroIntensity merged 3 commits into
python:mainfrom
reynoldsnlp:patch-1

Conversation

reynoldsnlp commented May 20, 2025 •
edited by ZeroIntensity
Loading

Copy link
Copy Markdown
Contributor

Paragraph should not be under slice.step. It applies to the whole class.

📚 Documentation preview 📚: https://cpython-previews--134393.org.readthedocs.build/en/134393/library/functions.html#slice

Update functions.rst
0c83a15 
Paragraph should not be under `slice.step`. It applies to the whole class.

python-cla-bot Bot commented May 20, 2025 •
edited
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

bedevere-app Bot added docs Documentation in the Doc dir skip news awaiting review labels May 20, 2025
github-project-automation Bot moved this to Todo in Docs PRs May 20, 2025
ZeroIntensity added needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes labels May 20, 2025

vstinner commented May 21, 2025

Copy link
Copy Markdown
Member

The change looks wrong.

ZeroIntensity commented May 21, 2025

Copy link
Copy Markdown
Member

What's wrong with it? That paragraph renders pretty weirdly on the current documentation.

vstinner commented May 21, 2025

Copy link
Copy Markdown
Member

The paragraph describes start, step and stop attributes, so I think that the current doc is correct. No?

ZeroIntensity commented May 21, 2025

Copy link
Copy Markdown
Member

Eh, it looks a little funny to me, particularly because it reads as being exclusive to step. I'd prefer we either change it to this, or move that paragraph to before start.

reynoldsnlp commented May 21, 2025

Copy link
Copy Markdown
Contributor Author

+1 for moving the paragraph above start/end/step. Should I commit that change?

ZeroIntensity commented Jun 25, 2025

Copy link
Copy Markdown
Member

Sorry for the late response. Go for it.

vstinner approved these changes Jun 25, 2025
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

ZeroIntensity merged commit 6227662 into python:main Jun 25, 2025
github-project-automation Bot moved this from Todo to Done in Docs PRs Jun 25, 2025

miss-islington-app Bot commented Jun 25, 2025

Copy link
Copy Markdown

Thanks @reynoldsnlp for the PR, and @ZeroIntensity for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 25, 2025
Docs: Fix indentation in slice class of functions.rst (pythonGH-1…
9f26705 
…34393)

Paragraph should not be under `slice.step`. It applies to the whole class.

---------
(cherry picked from commit 6227662)

Co-authored-by: Rob Reynolds <reynoldsnlp@users.noreply.github.com>
Co-authored-by: Rob Reynolds <13379223+reynoldsnlp@users.noreply.github.com>

bedevere-app Bot commented Jun 25, 2025

Copy link
Copy Markdown

GH-135948 is a backport of this pull request to the 3.14 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 25, 2025
Docs: Fix indentation in slice class of functions.rst (pythonGH-1…
9c4f4d9 
…34393)

Paragraph should not be under `slice.step`. It applies to the whole class.

---------
(cherry picked from commit 6227662)

Co-authored-by: Rob Reynolds <reynoldsnlp@users.noreply.github.com>
Co-authored-by: Rob Reynolds <13379223+reynoldsnlp@users.noreply.github.com>
bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jun 25, 2025

bedevere-app Bot commented Jun 25, 2025

Copy link
Copy Markdown

GH-135949 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jun 25, 2025

ZeroIntensity commented Jun 25, 2025

Copy link
Copy Markdown
Member

Congrats on your first contribution @reynoldsnlp :)

ZeroIntensity pushed a commit that referenced this pull request Jun 25, 2025
[3.13] Docs: Fix indentation in slice class of functions.rst (GH-…
335d7da 
…134393) (GH-135949)

Docs: Fix indentation in `slice` class of `functions.rst` (GH-134393)

Paragraph should not be under `slice.step`. It applies to the whole class.

(cherry picked from commit 6227662)

Co-authored-by: Rob Reynolds <13379223+reynoldsnlp@users.noreply.github.com>
ZeroIntensity pushed a commit that referenced this pull request Jun 25, 2025
[3.14] Docs: Fix indentation in slice class of functions.rst (GH-…
39bbf59 
…134393) (#135948)

Docs: Fix indentation in `slice` class of `functions.rst` (GH-134393)

Paragraph should not be under `slice.step`. It applies to the whole class.

(cherry picked from commit 6227662)

Co-authored-by: Rob Reynolds <13379223+reynoldsnlp@users.noreply.github.com>
reynoldsnlp deleted the patch-1 branch June 26, 2025 21:43
AndPuQing pushed a commit to AndPuQing/cpython that referenced this pull request Jul 11, 2025
Docs: Fix indentation in slice class of functions.rst (pythonGH-1…
e613aee 
…34393)

Paragraph should not be under `slice.step`. It applies to the whole class.

---------

Co-authored-by: Rob Reynolds <13379223+reynoldsnlp@users.noreply.github.com>
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
Docs: Fix indentation in slice class of functions.rst (pythonGH-1…
3fcb05c 
…34393)

Paragraph should not be under `slice.step`. It applies to the whole class.

---------

Co-authored-by: Rob Reynolds <13379223+reynoldsnlp@users.noreply.github.com>
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
Docs: Fix indentation in slice class of functions.rst (pythonGH-1…
be3a3d2 
…34393)

Paragraph should not be under `slice.step`. It applies to the whole class.

---------

Co-authored-by: Rob Reynolds <13379223+reynoldsnlp@users.noreply.github.com>
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
Docs: Fix indentation in slice class of functions.rst (pythonGH-1…
d81dbc9 
…34393)

Paragraph should not be under `slice.step`. It applies to the whole class.

---------

Co-authored-by: Rob Reynolds <13379223+reynoldsnlp@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner approved these changes
ZeroIntensity ZeroIntensity approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL