gh-132983: Refactor shared code in train_dict and finalize_dict - #134432
Merged
gpshead merged 1 commit intoMay 21, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
13 tasks
gpshead
approved these changes
May 21, 2025
Copy link
Copy Markdown
|
Thanks @emmatyping for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 21, 2025
…pythonGH-134432) Refactor shared code in train_dict and finalize_dict (cherry picked from commit c64a214) Co-authored-by: Emma Smith <emma@emmatyping.dev>
Copy link
Copy Markdown
|
GH-134442 is a backport of this pull request to the 3.14 branch. |
Sorry, something went wrong.
lkollar
pushed a commit
to lkollar/cpython
that referenced
this pull request
May 26, 2025
…pythonGH-134432) Refactor shared code in train_dict and finalize_dict
Pranjal095
pushed a commit
to Pranjal095/cpython
that referenced
this pull request
Jul 12, 2025
…pythonGH-134432) Refactor shared code in train_dict and finalize_dict
taegyunkim
pushed a commit
to taegyunkim/cpython
that referenced
this pull request
Aug 4, 2025
…pythonGH-134432) Refactor shared code in train_dict and finalize_dict
gostak-dd
pushed a commit
to gostak-dd/cpython
that referenced
this pull request
Jun 2, 2026
…pythonGH-134432) Refactor shared code in train_dict and finalize_dict
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors shared code between _zstd.train_dict and _zstd.finalize_dict, related to verifying and getting the size and number of samples.