[3.14] gh-127960 Fix the REPL to set the correct namespace by setting the correct __main__ module (gh-134275) - #134473
Merged
ambv merged 1 commit intoMay 22, 2025
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…the correct `__main__` module (pythongh-134275) The `__main__` module imported in the `_pyrepl` module points to the `_pyrepl` module itself when the interpreter was launched without `-m` option and didn't execute a module, while it's an unexpected behavior that `__main__` can be `_pyrepl` and relative imports such as `from . import *` works based on the `_pyrepl` module. (cherry picked from commit b1b8962) Co-authored-by: Yuichiro Tachibana (Tsuchiya) <t.yic.yt@gmail.com> Co-authored-by: Łukasz Langa <lukasz@langa.pl>
miss-islington
requested review from
ambv,
ericsnowcurrently,
lysnikolaou and
pablogsal
as code owners
May 22, 2025 00:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The __main__ module imported in the _pyrepl module points to the _pyrepl module itself when the interpreter was launched without -m option and didn't execute a module,
while it's an unexpected behavior that __main__ can be _pyrepl and relative imports such as from . import * works based on the _pyrepl module.
(cherry picked from commit b1b8962)
Co-authored-by: Yuichiro Tachibana (Tsuchiya) t.yic.yt@gmail.com
Co-authored-by: Łukasz Langa lukasz@langa.pl