Repository navigation
gh-134551: Add t-strings support to pprint - #134577
Merged
hugovk merged 9 commits intoApr 14, 2026
Merged
hugovk merged 9 commits into
hugovk merged 9 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
loic-simon
requested review from
AA-Turner,
AlexWaygood and
hugovk
as code owners
May 23, 2025 12:02
Copy link
Copy Markdown
Contributor
Author
|
Not sure why test.test_tokenize.TestRoundtrip.test_random_files fails on test_pprint.py? If I replace t-strings by f-strings it pass, is it an issue with the test not handling t-strings? Or a real issue with tokenizer round-trippring and t-strings? Edit: looks like a real problem, I have a MRE, opening an issue soon |
Sorry, something went wrong.
hugovk
reviewed
May 23, 2025
Comment thread
Lib/test/.ruff.toml
Outdated
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
AlexWaygood
removed their request for review
June 16, 2025 22:36
Copy link
Copy Markdown
Member
|
I've updated this PR to fix the merge conflict, add support for the new expand=True from #136964, and add this to What's New. >>> from pprint import pp
>>> name = "World"
>>> pp(t"Hello {name}")
Template(strings=('Hello ', ''),
interpolations=(Interpolation('World', 'name', None, ''),))
>>> pp(t"Hello {name}", expand=True)
Template(
strings=('Hello ', ''),
interpolations=(Interpolation('World', 'name', None, ''),),
) |
Sorry, something went wrong.
hugovk
approved these changes
Apr 13, 2026
ljfp
pushed a commit
to ljfp/cpython
that referenced
this pull request
Apr 25, 2026
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle formatting of Template and Interpolation types in pprint functions:
Very straightforward, using existing PrettyPrinter helper methods.
To avoid slowing import time, I did not import Template and Interpolation from string.templatelib, but instead copied their (very simple) definition:
cpython/Lib/string/templatelib.py
Lines 8 to 11 in 99a9ab1