FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

GH-130328: Fix WindowsConsoleGetEventTests after gh-133728 by chris-eibl · Pull Request #134660 · python/cpython · GitHub

/ cpython Public

GH-130328: Fix WindowsConsoleGetEventTests after gh-133728 - #134660

Merged
ambv merged 1 commit into
python:mainfrom
chris-eibl:fix_WindowsConsoleGetEventTests
May 25, 2025
ConversationCommits (1)ChecksFiles changed
Merged

GH-130328: Fix WindowsConsoleGetEventTests after gh-133728#134660
ambv merged 1 commit into
python:mainfrom
chris-eibl:fix_WindowsConsoleGetEventTests

Conversation

chris-eibl commented May 25, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

Fixes the WindowsConsoleGetEventTests which got broken due to moving wait into get_event in WindowsConsole during #133728.

bedevere-app Bot added awaiting review tests Tests in the Lib/test dir labels May 25, 2025
ambv changed the title fix WindowsConsoleGetEventTests after PR-133728 GH-130328: Fix WindowsConsoleGetEventTests after gh-133728 May 25, 2025
ambv removed the skip issue label May 25, 2025
bedevere-app Bot mentioned this pull request May 25, 2025
Closed

ambv commented May 25, 2025

Copy link
Copy Markdown
Contributor

!buildbot Windows10

bedevere-bot commented May 25, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @ambv for commit 7f15126 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F134660%2Fmerge

The command will test the builders whose names match following regular expression: Windows10

The builders matched are:

  • AMD64 Windows10 PR

ambv commented May 25, 2025

Copy link
Copy Markdown
Contributor

Buildbot looks happy now!

ambv merged commit 1000283 into python:main May 25, 2025
ambv added awaiting review needs backport to 3.14 bugs and security fixes labels May 25, 2025

miss-islington-app Bot commented May 25, 2025

Copy link
Copy Markdown

Thanks @chris-eibl for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 25, 2025
pythonGH-130328: Fix WindowsConsoleGetEventTests after pythongh-133728 (
0422edf 
pythongh-134660)

(cherry picked from commit 1000283)

Co-authored-by: Chris Eibl <138194463+chris-eibl@users.noreply.github.com>

bedevere-app Bot commented May 25, 2025

Copy link
Copy Markdown

GH-134666 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label May 25, 2025
ambv pushed a commit that referenced this pull request May 25, 2025
[3.14] GH-130328: Fix WindowsConsoleGetEventTests after gh-133728 (gh…
6917fbf 
…-134660) (gh-134666)

(cherry picked from commit 1000283)

Co-authored-by: Chris Eibl <138194463+chris-eibl@users.noreply.github.com>
chris-eibl deleted the fix_WindowsConsoleGetEventTests branch May 26, 2025 05:55
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
pythonGH-130328: Fix WindowsConsoleGetEventTests after pythongh-133728 (
c248bcb 
pythongh-134660)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
pythonGH-130328: Fix WindowsConsoleGetEventTests after pythongh-133728 (
3a120b1 
pythongh-134660)
gostak-dd pushed a commit to gostak-dd/cpython that referenced this pull request Jun 2, 2026
pythonGH-130328: Fix WindowsConsoleGetEventTests after pythongh-133728 (
0d7b88f 
pythongh-134660)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

pablogsal Awaiting requested review from pablogsal pablogsal is a code owner
lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner
ambv Awaiting requested review from ambv ambv is a code owner

Assignees

No one assigned

Labels

awaiting review skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL