gh-134657: Remove newly added private names from asyncio.__all__ - #134665
Merged
kumaraditya303 merged 3 commits intoJul 9, 2025
Merged
gh-134657: Remove newly added private names from asyncio.__all__#134665kumaraditya303 merged 3 commits into
kumaraditya303 merged 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This removes the names that were added in 3.14, so we can backport to the 3.14 branch. We can remove the remaining private names for 3.15 only in the main branch.
JelleZijlstra
requested review from
1st1,
asvetlov,
kumaraditya303 and
willingc
as code owners
May 25, 2025 18:03
JelleZijlstra
requested review from
cjw296,
gpshead,
picnixz and
vsajip
as code owners
May 25, 2025 18:28
picnixz
approved these changes
May 25, 2025
picnixz
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Good to know that I'm a code owner of the ssl tests in asyncio...
Sorry, something went wrong.
Comment thread
Misc/NEWS.d/next/Library/2025-05-25-11-02-05.gh-issue-134657.3YFhR9.rst
Outdated
…YFhR9.rst Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Copy link
Copy Markdown
Contributor
|
As I commented on the issue, I don't see value in making these changes, it changes almost 47 files which I was trying to avoid in the first place. All of these would be removed in 3.16 anyways so I think it is fine to keep it for now. |
Sorry, something went wrong.
gpshead
approved these changes
Jul 8, 2025
gpshead
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
thanks! these should not have been added to the __all__ public API surface.
Sorry, something went wrong.
kumaraditya303
approved these changes
Jul 9, 2025
Copy link
Copy Markdown
|
Thanks @JelleZijlstra for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 9, 2025
pythonGH-134665) (cherry picked from commit 797abd1) Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Copy link
Copy Markdown
|
GH-136455 is a backport of this pull request to the 3.14 branch. |
Sorry, something went wrong.
kumaraditya303
pushed a commit
that referenced
this pull request
Jul 9, 2025
AndPuQing
pushed a commit
to AndPuQing/cpython
that referenced
this pull request
Jul 11, 2025
Pranjal095
pushed a commit
to Pranjal095/cpython
that referenced
this pull request
Jul 12, 2025
picnixz
pushed a commit
to picnixz/cpython
that referenced
this pull request
Jul 13, 2025
taegyunkim
pushed a commit
to taegyunkim/cpython
that referenced
this pull request
Aug 4, 2025
Agent-Hellboy
pushed a commit
to Agent-Hellboy/cpython
that referenced
this pull request
Aug 19, 2025
kumaraditya303
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 9, 2025
….__all__ (pythonGH-134665) (python#136455) pythongh-134657: Remove newly added private names from asyncio.__all__ (pythonGH-134665) (cherry picked from commit 797abd1) Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the names that were added in 3.14, so we can backport to the 3.14 branch.
We can remove the remaining private names for 3.15 only in the main branch.