gh-134557: Suppress immortalization in _PyCode_GetScriptXIData under free-threading - #134686
gh-134557: Suppress immortalization in _PyCode_GetScriptXIData under free-threading#134686ericsnowcurrently merged 1 commit into
Conversation
Sorry, something went wrong.
This comment was marked as outdated.
ericsnowcurrently
left a comment
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
|
🤖 New build scheduled with the buildbot fleet by @emmatyping for commit 4dac776 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F134686%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again. |
Sorry, something went wrong.
|
Oh, the refleak buildbots won't catch any leaks because there aren't any tests that could trigger a leak. My mistake🤦♀️ |
Sorry, something went wrong.
colesbury
left a comment
There was a problem hiding this comment.
Thanks
Sorry, something went wrong.
emmatyping
left a comment
There was a problem hiding this comment.
I think this makes sense.
Sorry, something went wrong.
|
Thanks @neonene for the PR, and @ericsnowcurrently for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
Sorry, something went wrong.
…under free-threading (pythongh-134686) Disable immortalization around Py_CompileString*(). The same approach as 332356b that fixed the refleaks in compile() and eval(). (cherry picked from commit c60f39a) Co-authored-by: neonene <53406459+neonene@users.noreply.github.com> E: 09e72cf can pass test_capi, test_sys and test__interpchannels with this patch for me.
|
GH-134738 is a backport of this pull request to the 3.14 branch. |
Sorry, something went wrong.
… under free-threading (gh134738) Disable immortalization around Py_CompileString*(). The same approach as 332356b that fixed the refleaks in compile() and eval(). E: 09e72cf can pass test_capi, test_sys and test__interpchannels with this patch for me. (cherry picked from commit c60f39a, AKA gh-134686) Co-authored-by: neonene <53406459+neonene@users.noreply.github.com>
…under free-threading (pythongh-134686) Disable immortalization around Py_CompileString*(). The same approach as 332356b that fixed the refleaks in compile() and eval(). E: 09e72cf can pass test_capi, test_sys and test__interpchannels with this patch for me.
…under free-threading (pythongh-134686) Disable immortalization around Py_CompileString*(). The same approach as 332356b that fixed the refleaks in compile() and eval(). E: 09e72cf can pass test_capi, test_sys and test__interpchannels with this patch for me.
…under free-threading (pythongh-134686) Disable immortalization around Py_CompileString*(). The same approach as 332356b that fixed the refleaks in compile() and eval(). E: 09e72cf can pass test_capi, test_sys and test__interpchannels with this patch for me.
The same approach as 332356b that fixed the refleaks in compile() and eval().
cc @colesbury @ericsnowcurrently @emmatyping I'm not so confident.
E: 09e72cf can pass test_capi, test_sys and test__interpchannels with this patch for me.