FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-91048: Correct Apple platform includes for iOS by freakboy3742 · Pull Request #134712 · python/cpython · GitHub

/ cpython Public

gh-91048: Correct Apple platform includes for iOS - #134712

Merged
freakboy3742 merged 1 commit into
python:mainfrom
freakboy3742:fix-apple-includes
May 26, 2025
ConversationCommits (1)ChecksFiles changed
Merged

gh-91048: Correct Apple platform includes for iOS#134712
freakboy3742 merged 1 commit into
python:mainfrom
freakboy3742:fix-apple-includes

Conversation

freakboy3742 commented May 26, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

#134652 introduced some modifications to support remote debugging; however the platform #defines (in particular the ones on L103, L138 and L170) was incorrectly including iOS in the usage, but not in the definition of the pid_to_task symbol.

The pid_to_task implementation depends on libproc.h and mach/mach-vm.h, which aren't available on iOS.

bedevere-app Bot mentioned this pull request May 26, 2025
Closed

freakboy3742 commented May 26, 2025

Copy link
Copy Markdown
Contributor Author

!buildbot iOS

bedevere-bot commented May 26, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit c5f5619 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F134712%2Fmerge

The command will test the builders whose names match following regular expression: iOS

The builders matched are:

  • iOS ARM64 Simulator PR

freakboy3742 requested a review from pablogsal May 26, 2025 12:15
freakboy3742 changed the title gh-94018: Correct Apple platform includes for iOS. gh-91048: Correct Apple platform includes for iOS. May 26, 2025
bedevere-app Bot mentioned this pull request May 26, 2025
Closed
freakboy3742 enabled auto-merge (squash) May 26, 2025 12:23
AA-Turner changed the title gh-91048: Correct Apple platform includes for iOS. gh-91048: Correct Apple platform includes for iOS May 26, 2025
freakboy3742 merged commit 965662e into python:main May 26, 2025
freakboy3742 deleted the fix-apple-includes branch May 26, 2025 12:44

miss-islington-app Bot commented May 26, 2025

Copy link
Copy Markdown

Thanks @freakboy3742 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 26, 2025
pythongh-91048: Correct Apple platform includes for iOS. (pythonGH-13…
25493d3 
…4712)

Correct Apple platform includes for iOS.
(cherry picked from commit 965662e)

Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>

bedevere-app Bot commented May 26, 2025

Copy link
Copy Markdown

GH-134714 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label May 26, 2025
freakboy3742 added a commit that referenced this pull request May 26, 2025
[3.14] gh-91048: Correct Apple platform includes for iOS. (GH-134712) (…
6c917cb 
…#134714)

Correct Apple platform includes for iOS.
(cherry picked from commit 965662e)

Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
pythongh-91048: Correct Apple platform includes for iOS. (python#134712)
4312701 
Correct Apple platform includes for iOS.
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
pythongh-91048: Correct Apple platform includes for iOS. (python#134712)
62c3206 
Correct Apple platform includes for iOS.
gostak-dd pushed a commit to gostak-dd/cpython that referenced this pull request Jun 2, 2026
pythongh-91048: Correct Apple platform includes for iOS. (python#134712)
5139145 
Correct Apple platform includes for iOS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

pablogsal pablogsal approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL