gh-132775: Always Set __builtins__ In _PyFunction_FromXIData() - #134758
Merged
ericsnowcurrently merged 3 commits intoMay 27, 2025
Merged
gh-132775: Always Set __builtins__ In _PyFunction_FromXIData()#134758ericsnowcurrently merged 3 commits into
ericsnowcurrently merged 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Comment thread
Python/crossinterp_data_lookup.h
Outdated
Comment thread
Python/crossinterp_data_lookup.h
ericsnowcurrently
enabled auto-merge (squash)
May 27, 2025 15:17
ZeroIntensity
approved these changes
May 27, 2025
ZeroIntensity
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Might as well throw a checkmark on here :)
Sorry, something went wrong.
Copy link
Copy Markdown
|
Thanks @ericsnowcurrently for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 27, 2025
…ythongh-134758) This is a small follow-up to pythongh-133481. There's a corner case in the behavior of PyImport_ImportModuleAttrString(), where it expects __builtins__ to be set if __globals__ is set. (cherry picked from commit 9b5e800) Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
Copy link
Copy Markdown
|
GH-134794 is a backport of this pull request to the 3.14 branch. |
Sorry, something went wrong.
ericsnowcurrently
added a commit
that referenced
this pull request
May 27, 2025
…gh-134794) This is a small follow-up to gh-133481. There's a corner case in the behavior of PyImport_ImportModuleAttrString(), where it expects __builtins__ to be set if __globals__ is set. (cherry picked from commit 9b5e800, AKA gh-134758) Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
Pranjal095
pushed a commit
to Pranjal095/cpython
that referenced
this pull request
Jul 12, 2025
…ythongh-134758) This is a small follow-up to pythongh-133481. There's a corner case in the behavior of PyImport_ImportModuleAttrString(), where it expects __builtins__ to be set if __globals__ is set.
taegyunkim
pushed a commit
to taegyunkim/cpython
that referenced
this pull request
Aug 4, 2025
…ythongh-134758) This is a small follow-up to pythongh-133481. There's a corner case in the behavior of PyImport_ImportModuleAttrString(), where it expects __builtins__ to be set if __globals__ is set.
gostak-dd
pushed a commit
to gostak-dd/cpython
that referenced
this pull request
Jun 2, 2026
…ythongh-134758) This is a small follow-up to pythongh-133481. There's a corner case in the behavior of PyImport_ImportModuleAttrString(), where it expects __builtins__ to be set if __globals__ is set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small follow-up to gh-133481. There's a corner case in the behavior of PyImport_ImportModuleAttrString() where it expects __builtins__ to be set if __globals__ is set.