FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-134160: Block multiple module initialization by encukou · Pull Request #134773 · python/cpython · GitHub

/ cpython Public

gh-134160: Block multiple module initialization - #134773

Merged
AA-Turner merged 4 commits into
python:mainfrom
encukou:extending-exec-once
May 28, 2025
ConversationCommits (4)ChecksFiles changed
Merged

gh-134160: Block multiple module initialization#134773
AA-Turner merged 4 commits into
python:mainfrom
encukou:extending-exec-once

Conversation

encukou commented May 27, 2025 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

Change the tutorial to block multiple module initialization, and note the reference leak.

📚 Documentation preview 📚: https://cpython-previews--134773.org.readthedocs.build/

bedevere-app Bot mentioned this pull request May 27, 2025
Open
bedevere-app Bot added docs Documentation in the Doc dir skip news labels May 27, 2025
github-project-automation Bot moved this to Todo in Docs PRs May 27, 2025

encukou commented May 27, 2025

Copy link
Copy Markdown
Member Author

There's a better way to do this, but module state might work better in Chapter 2?

neonene reviewed May 27, 2025
View reviewed changes
Comment thread Doc/extending/extending.rst Outdated
ZeroIntensity reviewed May 27, 2025
View reviewed changes

ZeroIntensity left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I just realized that we don't have any dedicated section on subinterpreters. I'd be happy to do that in a follow-up.

Comment thread Doc/extending/extending.rst Outdated
StanFromIreland reviewed May 27, 2025
View reviewed changes
Comment thread Doc/extending/extending.rst
encukou and others added 2 commits May 27, 2025 17:38
AA-Turner reviewed May 27, 2025
View reviewed changes
Comment thread Doc/extending/extending.rst Outdated
AA-Turner reviewed May 27, 2025
View reviewed changes
Comment thread Doc/extending/extending.rst
AA-Turner approved these changes May 27, 2025
View reviewed changes

AA-Turner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Two very minor suggestions, but otherwise let's get this merged quickly.

A

AA-Turner added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels May 27, 2025
Apply suggestions from code review
c562e2e 
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
AA-Turner merged commit 469a564 into python:main May 28, 2025
github-project-automation Bot moved this from Todo to Done in Docs PRs May 28, 2025

miss-islington-app Bot commented May 28, 2025

Copy link
Copy Markdown

Thanks @encukou for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 28, 2025
pythongh-134160: Block multiple module initialization (pythonGH-134773)
bd36c93 
(cherry picked from commit 469a564)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 28, 2025
pythongh-134160: Block multiple module initialization (pythonGH-134773)
6d5c370 
(cherry picked from commit 469a564)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>

bedevere-app Bot commented May 28, 2025

Copy link
Copy Markdown

GH-134827 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label May 28, 2025

bedevere-app Bot commented May 28, 2025

Copy link
Copy Markdown

GH-134828 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label May 28, 2025
encukou deleted the extending-exec-once branch May 28, 2025 07:56
AA-Turner added a commit that referenced this pull request May 28, 2025
[3.14] gh-134160: Block multiple module initialization (GH-134773) (#…
998cedb 
…134827)

gh-134160: Block multiple module initialization (GH-134773)
(cherry picked from commit 469a564)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
AA-Turner added a commit that referenced this pull request May 28, 2025
[3.13] gh-134160: Block multiple module initialization (GH-134773) (#…
067df2b 
…134828)

gh-134160: Block multiple module initialization (GH-134773)
(cherry picked from commit 469a564)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
pythongh-134160: Block multiple module initialization (python#134773)
6adbe96 
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
pythongh-134160: Block multiple module initialization (python#134773)
e8d345a 
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
gostak-dd pushed a commit to gostak-dd/cpython that referenced this pull request Jun 2, 2026
pythongh-134160: Block multiple module initialization (python#134773)
b49a480 
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ZeroIntensity ZeroIntensity left review comments
StanFromIreland StanFromIreland left review comments
AA-Turner AA-Turner approved these changes
+1 more reviewer
neonene neonene left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL