FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-134830: Fix reference in `Doc/extending/windows.rst` by StanFromIreland · Pull Request #134831 · python/cpython · GitHub

/ cpython Public

gh-134830: Fix reference in Doc/extending/windows.rst - #134831

Merged
encukou merged 5 commits into
python:mainfrom
StanFromIreland:link
Jun 2, 2025
ConversationCommits (5)ChecksFiles changed
Merged

gh-134830: Fix reference in Doc/extending/windows.rst#134831
encukou merged 5 commits into
python:mainfrom
StanFromIreland:link

Conversation

StanFromIreland commented May 28, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

bedevere-app Bot added awaiting review docs Documentation in the Doc dir skip news labels May 28, 2025
github-project-automation Bot moved this to Todo in Docs PRs May 28, 2025
StanFromIreland changed the title Fix reference in Doc/extending/windows.rst gh-134830: Fix reference in Doc/extending/windows.rst May 28, 2025
bedevere-app Bot mentioned this pull request May 28, 2025
Closed

befeleme commented May 28, 2025

Copy link
Copy Markdown
Contributor

Unfortunately this didn't help:
https://cpython-previews--134831.org.readthedocs.build/en/134831/extending/stable-abi

URL        `stable-abi'
Name       `Limited API'
Parent URL file:///builddir/build/BUILD/python3-docs-3.14.0_b2-build/Python-3.14.0b2/Doc/build/html/extending/windows.html, line 277, col 5
Real URL   file:///builddir/build/BUILD/python3-docs-3.14.0_b2-build/Python-3.14.0b2/Doc/build/html/extending/stable-abi
Check time 0.001 seconds
Result     Error: URLError: <urlopen error [Errno 2] No such file or directory: '/builddir/build/BUILD/python3-docs-3.14.0_b2-build/Python-3.14.0b2/Doc/build/html/extending/stable-abi'>

StanFromIreland commented May 28, 2025

Copy link
Copy Markdown
Member Author

Ah yes, I somehow did not notice that it wasn't a reference in the first place.

befeleme commented May 28, 2025

Copy link
Copy Markdown
Contributor

Perhaps the reference should be still point to the original <stable-application-binary-interface> as it refers to the whole section, rather that the sub-one?

hroncok reviewed May 29, 2025
View reviewed changes
Comment thread Doc/extending/windows.rst Outdated
Suggestion
2619d81 
Co-authored-by: Miro Hrončok <miro@hroncok.cz>

hroncok commented May 29, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

So, the problem is, the reference does not exist. It needs to be added to Doc/c-api/stable.rst

Above

cpython/Doc/c-api/stable.rst

Line 55 in e64395e

Stable Application Binary Interface

I cannot do that by suggestion.

StanFromIreland requested a review from encukou as a code owner May 29, 2025 11:39

encukou commented Jun 2, 2025

Copy link
Copy Markdown
Member

Is this the only issue in Doc/using/windows.rst? If it is, the file should be removed from Doc/tools/.nitignore.

(I'm away from the computer now, will be able to check tomorrow)

StanFromIreland commented Jun 2, 2025

Copy link
Copy Markdown
Member Author

If there are other issues I don’t mind fixing them all, I can get to it later in the week.

encukou commented Jun 2, 2025

Copy link
Copy Markdown
Member

I checked; some nitpicks about environment variables remain.
Thank you for the improvement!

encukou merged commit 0ac9e17 into python:main Jun 2, 2025
github-project-automation Bot moved this from Todo to Done in Docs PRs Jun 2, 2025
encukou added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jun 2, 2025

miss-islington-app Bot commented Jun 2, 2025

Copy link
Copy Markdown

Thanks @StanFromIreland for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington-app Bot commented Jun 2, 2025

Copy link
Copy Markdown

Thanks @StanFromIreland for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

encukou added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes and removed needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jun 3, 2025

miss-islington-app Bot commented Jun 3, 2025

Copy link
Copy Markdown

Thanks @StanFromIreland for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington-app Bot commented Jun 3, 2025

Copy link
Copy Markdown

Thanks @StanFromIreland for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 3, 2025
pythongh-134830: Fix reference in Doc/extending/windows.rst (python…
04f607d 
…GH-134831)

(cherry picked from commit 0ac9e17)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Miro Hrončok <miro@hroncok.cz>

miss-islington-app Bot commented Jun 3, 2025

Copy link
Copy Markdown

Sorry, @StanFromIreland and @encukou, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 0ac9e17fb47075c9446b99da4dffe4cad993b97a 3.13

bedevere-app Bot commented Jun 3, 2025

Copy link
Copy Markdown

GH-135058 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jun 3, 2025
encukou removed the needs backport to 3.13 bugs and security fixes label Jun 3, 2025
encukou pushed a commit that referenced this pull request Jun 3, 2025
[3.14] gh-134830: Fix reference in Doc/extending/windows.rst (GH-13…
d420d82 
…4831) (GH-135058)

(cherry picked from commit 0ac9e17)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Miro Hrončok <miro@hroncok.cz>
StanFromIreland deleted the link branch June 3, 2025 07:14

StanFromIreland commented Jun 3, 2025

Copy link
Copy Markdown
Member Author

I will check them out later.

Apologies I am unable to backport:-(

Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
pythongh-134830: Fix reference in Doc/extending/windows.rst (python…
e6510ae 
…GH-134831)

Co-authored-by: Miro Hrončok <miro@hroncok.cz>
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
pythongh-134830: Fix reference in Doc/extending/windows.rst (python…
4dc48bf 
…GH-134831)

Co-authored-by: Miro Hrončok <miro@hroncok.cz>
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
pythongh-134830: Fix reference in Doc/extending/windows.rst (python…
3f40ea4 
…GH-134831)

Co-authored-by: Miro Hrončok <miro@hroncok.cz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

encukou Awaiting requested review from encukou encukou is a code owner
2 more reviewers
hroncok hroncok approved these changes
befeleme befeleme approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

encukou

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL