FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-132983: Minor fixes and clean up for the _zstd module by serhiy-storchaka · Pull Request #134930 · python/cpython · GitHub

/ cpython Public

gh-132983: Minor fixes and clean up for the _zstd module - #134930

Merged
serhiy-storchaka merged 9 commits into
python:mainfrom
serhiy-storchaka:zstd-fixes
Jun 1, 2025
ConversationCommits (9)ChecksFiles changed
Merged

gh-132983: Minor fixes and clean up for the _zstd module#134930
serhiy-storchaka merged 9 commits into
python:mainfrom
serhiy-storchaka:zstd-fixes

Conversation

serhiy-storchaka commented May 30, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

bedevere-app Bot mentioned this pull request May 30, 2025
Closed
13 tasks
emmatyping reviewed May 30, 2025
View reviewed changes

emmatyping left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

One question and one concern, but the rest looks good! Thank you for the improvements :)

Comment thread Modules/_zstd/compressor.c Outdated
Comment thread Modules/_zstd/decompressor.c Outdated
AA-Turner reviewed May 31, 2025
View reviewed changes
Comment thread Modules/_zstd/_zstdmodule.c
Comment on lines -510 to -515
if (!PyType_Check(c_parameter_type) || !PyType_Check(d_parameter_type)) {
PyErr_SetString(PyExc_ValueError,
"The two arguments should be CompressionParameter and "
"DecompressionParameter types.");
return NULL;
}

AA-Turner May 31, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Sanity check on removing the type checks here?

emmatyping May 31, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The type checks are already handled by argument clinic, so these are actually redundant.

Comment thread Modules/_zstd/compressor.c Outdated
Comment thread Modules/_zstd/decompressor.c Outdated
emmatyping approved these changes May 31, 2025
View reviewed changes

emmatyping left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The changes look good! One minor wording suggestion but great otherwise. Thank you!

Comment thread Modules/_zstd/_zstdmodule.c Outdated
Comment thread Modules/_zstd/_zstdmodule.c
serhiy-storchaka and others added 2 commits June 1, 2025 09:04
Update Modules/_zstd/_zstdmodule.c
b15f2e4 
Co-authored-by: Emma Smith <emma@emmatyping.dev>
Update tests.
fe83254
serhiy-storchaka merged commit b595237 into python:main Jun 1, 2025

miss-islington-app Bot commented Jun 1, 2025

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 1, 2025
pythongh-132983: Minor fixes and clean up for the _zstd module (pytho…
7275ec4 
…nGH-134930)

(cherry picked from commit b595237)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

bedevere-app Bot commented Jun 1, 2025

Copy link
Copy Markdown

GH-134998 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jun 1, 2025

serhiy-storchaka commented Jun 1, 2025

Copy link
Copy Markdown
Member Author

Thank you @AA-Turner and @emmatyping for your review.

serhiy-storchaka deleted the zstd-fixes branch June 1, 2025 08:23
serhiy-storchaka added a commit that referenced this pull request Jun 1, 2025
[3.14] gh-132983: Minor fixes and clean up for the _zstd module (GH-1…
035c4d6 
…34930) (GH-134998)

(cherry picked from commit b595237)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
pythongh-132983: Minor fixes and clean up for the _zstd module (pytho…
7be1b25 
…nGH-134930)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
pythongh-132983: Minor fixes and clean up for the _zstd module (pytho…
38e3634 
…nGH-134930)
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
pythongh-132983: Minor fixes and clean up for the _zstd module (pytho…
9acbfcc 
…nGH-134930)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

AA-Turner AA-Turner left review comments
emmatyping emmatyping approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL