[3.14] gh-91048: Reorder result tuple of parse_code_object (GH-134898) - #134956
Merged
pablogsal merged 3 commits intoJun 11, 2025
Merged
[3.14] gh-91048: Reorder result tuple of parse_code_object (GH-134898)#134956pablogsal merged 3 commits into
pablogsal merged 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…34898) Reorder result tuple of parse_code_object The standard followed by APIs like pstat.Stats is to take a file, line, function triplet. The parse_code_object function (and callers exposing this in Python like RemoteUnwinder.get_stack_trace) return function, file, line triplets which requires the caller to reorder these when using it in classes like pstat.Stats. (cherry picked from commit 8e8786f) Co-authored-by: László Kiss Kollár <kiss.kollar.laszlo@gmail.com>
pablogsal
approved these changes
May 31, 2025
pablogsal
requested review from
asvetlov,
kumaraditya303 and
willingc
as code owners
May 31, 2025 00:53
pablogsal
enabled auto-merge (squash)
May 31, 2025 00:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reorder result tuple of parse_code_object
The standard followed by APIs like pstat.Stats is to take a file, line,
function triplet. The parse_code_object function (and callers exposing
this in Python like RemoteUnwinder.get_stack_trace) return function,
file, line triplets which requires the caller to reorder these when
using it in classes like pstat.Stats.
(cherry picked from commit 8e8786f)
Co-authored-by: László Kiss Kollár kiss.kollar.laszlo@gmail.com