gh-91048: Reorder result tuple in asyncio/tools.py - #134957
Closed
pablogsal wants to merge 1 commit into
Closed
Conversation
pablogsal
requested review from
1st1,
asvetlov,
kumaraditya303 and
willingc
as code owners
May 31, 2025 00:55
pablogsal
enabled auto-merge (squash)
May 31, 2025 00:55
kumaraditya303
requested changes
Jul 8, 2025
kumaraditya303
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
There are merge conflicts, and there are test failures. Why is this needed?
Sorry, something went wrong.
Copy link
Copy Markdown
|
When you're done making the requested changes, leave the comment: I have made the requested changes; please review again. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
This has been fixed in a different PR |
Sorry, something went wrong.
auto-merge was automatically disabled
July 8, 2025 12:22
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.