FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-134280: Disable constant folding for ~ with a boolean argument by serhiy-storchaka · Pull Request #134982 · python/cpython · GitHub

/ cpython Public

gh-134280: Disable constant folding for ~ with a boolean argument - #134982

Merged
serhiy-storchaka merged 4 commits into
python:mainfrom
serhiy-storchaka:constant-folding-invert-bool
Jul 1, 2025
ConversationCommits (4)ChecksFiles changed
Merged

gh-134280: Disable constant folding for ~ with a boolean argument#134982
serhiy-storchaka merged 4 commits into
python:mainfrom
serhiy-storchaka:constant-folding-invert-bool

Conversation

serhiy-storchaka commented May 31, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

This moves the deprecation warning from compile time to runtime.

pythongh-134280: Disable constant folding for ~ with a boolean argument
deb1724 
This moves the deprecation warning from compile time to runtime.
serhiy-storchaka added the needs backport to 3.14 bugs and security fixes label May 31, 2025
bedevere-app Bot mentioned this pull request May 31, 2025
Closed

serhiy-storchaka commented May 31, 2025

Copy link
Copy Markdown
Member Author

3.14 and 3.13 differ from main, so I would do backporting step by step.

Eclips4 self-requested a review May 31, 2025 20:05

iritkatriel commented Jun 1, 2025

Copy link
Copy Markdown
Member

If we can detect this in https://github.com/python/cpython/blob/main/Python/ast_preprocess.c then we get the warning in both static analysis and execution.

serhiy-storchaka commented Jun 1, 2025

Copy link
Copy Markdown
Member Author

Yes, but we only add SyntaxWarning for very common errors. ~True is unlikely used in real code.

iritkatriel commented Jun 1, 2025

Copy link
Copy Markdown
Member

Is it hard to detect this in the preprocessor?

serhiy-storchaka commented Jun 1, 2025

Copy link
Copy Markdown
Member Author

I do not know. But even a couple lines of code is a high price for this feature. And it will be more than a couple lines.

timhoffm reviewed Jun 1, 2025
View reviewed changes
Comment thread Python/flowgraph.c Outdated
serhiy-storchaka merged commit 86c3316 into python:main Jul 1, 2025

miss-islington-app Bot commented Jul 1, 2025

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

serhiy-storchaka deleted the constant-folding-invert-bool branch July 1, 2025 17:24
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 1, 2025
pythongh-134280: Disable constant folding for ~ with a boolean argume…
cd7164f 
…nt (pythonGH-134982)

This moves the deprecation warning from compile time to run time.
(cherry picked from commit 86c3316)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

bedevere-app Bot commented Jul 1, 2025

Copy link
Copy Markdown

GH-136185 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jul 1, 2025
serhiy-storchaka added a commit that referenced this pull request Jul 2, 2025
[3.14] gh-134280: Disable constant folding for ~ with a boolean argum…
8ba024d 
…ent (GH-134982) (GH-136185)

This moves the deprecation warning from compile time to run time.
(cherry picked from commit 86c3316)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
AndPuQing pushed a commit to AndPuQing/cpython that referenced this pull request Jul 11, 2025
pythongh-134280: Disable constant folding for ~ with a boolean argume…
32da324 
…nt (pythonGH-134982)

This moves the deprecation warning from compile time to run time.
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
pythongh-134280: Disable constant folding for ~ with a boolean argume…
102920b 
…nt (pythonGH-134982)

This moves the deprecation warning from compile time to run time.
picnixz pushed a commit to picnixz/cpython that referenced this pull request Jul 13, 2025
pythongh-134280: Disable constant folding for ~ with a boolean argume…
7fd5590 
…nt (pythonGH-134982)

This moves the deprecation warning from compile time to run time.
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
pythongh-134280: Disable constant folding for ~ with a boolean argume…
ffefde0 
…nt (pythonGH-134982)

This moves the deprecation warning from compile time to run time.
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
pythongh-134280: Disable constant folding for ~ with a boolean argume…
37481cd 
…nt (pythonGH-134982)

This moves the deprecation warning from compile time to run time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

markshannon Awaiting requested review from markshannon markshannon is a code owner
iritkatriel Awaiting requested review from iritkatriel iritkatriel is a code owner
Eclips4 Awaiting requested review from Eclips4 Eclips4 is a code owner
1 more reviewer
timhoffm timhoffm left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL