FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-131798: JIT: replace _CHECK_METHOD_VERSION with _CHECK_FUNCTION_VERSION_INLINE by Zheaoli · Pull Request #135022 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-131798: JIT: replace _CHECK_METHOD_VERSION with _CHECK_FUNCTION_VERSION_INLINE - #135022

Merged
Fidget-Spinner merged 10 commits into
python:mainfrom
Zheaoli:manjusaka/method-version
Jun 16, 2025
ConversationCommits (10)ChecksFiles changed
Merged

gh-131798: JIT: replace _CHECK_METHOD_VERSION with _CHECK_FUNCTION_VERSION_INLINE#135022
Fidget-Spinner merged 10 commits into
python:mainfrom
Zheaoli:manjusaka/method-version

Conversation

Zheaoli commented Jun 2, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

Zheaoli added 3 commits June 2, 2025 20:13
pythongh-131798: JIT: replace _CHECK_METHOD_VERSION with _CHECK_FUNCT…
7bc5cf6 
…ION_VERSION_INLINE

Signed-off-by: Manjusaka <me@manjusaka.me>
Update news
baaff8e 
Signed-off-by: Manjusaka <me@manjusaka.me>
Merge branch 'main' of https://github.com/python/cpython into manjusa…
4e13d21 
…ka/method-version
Zheaoli requested a review from Fidget-Spinner as a code owner June 2, 2025 12:14
bedevere-app Bot mentioned this pull request Jun 2, 2025
Open
Zheaoli added 2 commits June 2, 2025 20:15
fix code style
68f93b5 
Signed-off-by: Manjusaka <me@manjusaka.me>
fix code style
cc8ecf1 
Signed-off-by: Manjusaka <me@manjusaka.me>
brandtbucher reviewed Jun 6, 2025
View reviewed changes

brandtbucher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Very cool, thanks! A few suggestions:

Comment thread Misc/NEWS.d/next/Core_and_Builtins/2025-06-02-20-13-37.gh-issue-131798.JQRFvR.rst Outdated
Comment thread Python/optimizer_bytecodes.c Outdated
Comment thread Lib/test/test_capi/test_opt.py
Comment on lines +2239 to +2245
class TestObject:
def test(self, *args, **kwargs):
return args[0]

test_object = TestObject()
test_bound_method = TestObject.test.__get__(test_object)

brandtbucher Jun 6, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can you move this into test_method_guards_removed_or_reduced? global_identity needs to be at module scope for other reasons that don't apply here.

Also, I think it can be simplified to something like:

class TestObject:
    def test(self, arg):
        return arg

test_bound_method = TestObject().test

Zheaoli Jun 7, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

If I'm correct, TestObject().test will just generate _CHECK_FUNCTION_VERSION code, It's a normal function.

Reference the test code here

Zheaoli Jun 7, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can you move this into test_method_guards_removed_or_reduced? global_identity needs to be at module scope for other reasons that don't apply here.

BTW, if I push the test object into the test_method_guards_removed_or_reduced. I think the method will not be treated by a const. So we the _CHECK_FUNCTION_VERSION_INLINE is not exist in final opcode.

Fidget-Spinner Jun 15, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@Zheaoli is right here. Can you please move this back to global scope? It seems tests are failing as the global method is not being promoted to a constant.

Zheaoli Jun 15, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can you please move this back to global scope? It seems tests are failing as the global method is not being promoted to a constant.

Sure

Comment thread Lib/test/test_capi/test_opt.py Outdated
Zheaoli and others added 4 commits June 7, 2025 08:16
Update Misc/NEWS.d/next/Core_and_Builtins/2025-06-02-20-13-37.gh-issu…
2841780 
…e-131798.JQRFvR.rst

Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>
fix review idea
41838e9 
Signed-off-by: Manjusaka <me@manjusaka.me>
Merge main
cc87439 
Signed-off-by: Manjusaka <me@manjusaka.me>
lint code
37bac81 
Signed-off-by: Manjusaka <me@manjusaka.me>
Fidget-Spinner approved these changes Jun 9, 2025
View reviewed changes

Fidget-Spinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Sorry for forgetting to review this. This looks like a good optimization --- _CHECK_FUNCTION_VERSION_INLINE has one fewer memory indirection than _CHECK_METHOD_VERSION

Zheaoli commented Jun 15, 2025

Copy link
Copy Markdown
Contributor Author

@brandtbucher I update some idea about the test, PTAL when you got time.

fix code
9ce01b0 
Signed-off-by: Manjusaka <me@manjusaka.me>
Fidget-Spinner merged commit 667a86e into python:main Jun 16, 2025
Zheaoli deleted the manjusaka/method-version branch June 16, 2025 05:58
lkollar pushed a commit to lkollar/cpython that referenced this pull request Jun 19, 2025
pythongh-131798: JIT: replace _CHECK_METHOD_VERSION with _CHECK_FUNCT…
ac2e02c 
…ION_VERSION_INLINE (pythonGH-135022)

Signed-off-by: Manjusaka <me@manjusaka.me>
Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
pythongh-131798: JIT: replace _CHECK_METHOD_VERSION with _CHECK_FUNCT…
25a9cf9 
…ION_VERSION_INLINE (pythonGH-135022)

Signed-off-by: Manjusaka <me@manjusaka.me>
Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
pythongh-131798: JIT: replace _CHECK_METHOD_VERSION with _CHECK_FUNCT…
fe4021d 
…ION_VERSION_INLINE (pythonGH-135022)

Signed-off-by: Manjusaka <me@manjusaka.me>
Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
pythongh-131798: JIT: replace _CHECK_METHOD_VERSION with _CHECK_FUNCT…
f7d1e41 
…ION_VERSION_INLINE (pythonGH-135022)

Signed-off-by: Manjusaka <me@manjusaka.me>
Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

brandtbucher brandtbucher left review comments
Fidget-Spinner Fidget-Spinner approved these changes

Assignees

No one assigned

Labels

topic-JIT

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL