gh-135034: Normalize link targets in tarfile, add os.path.realpath(strict='allow_missing') - #135037
Merged
Yhg1s merged 20 commits intoJun 3, 2025
Merged
gh-135034: Normalize link targets in tarfile, add os.path.realpath(strict='allow_missing')#135037Yhg1s merged 20 commits into
Yhg1s merged 20 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…path(strict='allow_missing')` Addresses CVEs 2024-12718, 2025-4138, 2025-4330, and 2025-4517. Co-authored-by: Petr Viktorin <encukou@gmail.com> Signed-off-by: Łukasz Langa <lukasz@langa.pl>
AA-Turner
reviewed
Jun 2, 2025
Comment thread
Lib/test/test_tarfile.py
Outdated
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
encukou
reviewed
Jun 2, 2025
Comment thread
Lib/test/test_tarfile.py
Outdated
encukou
reviewed
Jun 2, 2025
Comment thread
Lib/test/test_ntpath.py
Outdated
Copy link
Copy Markdown
Member
To align with this, there'd be a ntpath.ALLOW_MISSING singleton rather than an 'allow_missing' string. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
🤖 New build scheduled with the buildbot fleet by @encukou for commit 5af66c6 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F135037%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
Sorry, something went wrong.
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
This reverts commit fd2013a.
This was referenced Aug 17, 2026
This was referenced Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses CVEs 2024-12718, 2025-4138, 2025-4330, and 2025-4517.
[edit @encukou]: Also addresses CVE-2025-4435. Sorry for leaving that out of the commit messages.
Co-authored-by: Petr Viktorin encukou@gmail.com
Signed-off-by: Łukasz Langa lukasz@langa.pl
📚 Documentation preview 📚: https://cpython-previews--135037.org.readthedocs.build/