gh-134160: Use PyModuleDef.m_free in the example module xxlimited - #135174
Merged
encukou merged 3 commits intoJun 6, 2025
Merged
gh-134160: Use PyModuleDef.m_free in the example module xxlimited#135174encukou merged 3 commits into
encukou merged 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
neonene
reviewed
Jun 6, 2025
Comment thread
Modules/xxlimited.c
Co-authored-by: neonene <53406459+neonene@users.noreply.github.com>
encukou
enabled auto-merge (squash)
June 6, 2025 11:48
vstinner
approved these changes
Jun 6, 2025
vstinner
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM.
You should merge main into your branch to retrieve the test_syntax fix.
Sorry, something went wrong.
Copy link
Copy Markdown
|
Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 6, 2025
…ed (pythonGH-135174) (cherry picked from commit 1adca08) Co-authored-by: Petr Viktorin <encukou@gmail.com> Co-authored-by: neonene <53406459+neonene@users.noreply.github.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 6, 2025
…ed (pythonGH-135174) (cherry picked from commit 1adca08) Co-authored-by: Petr Viktorin <encukou@gmail.com> Co-authored-by: neonene <53406459+neonene@users.noreply.github.com>
Copy link
Copy Markdown
|
GH-135213 is a backport of this pull request to the 3.14 branch. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-135214 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
Pranjal095
pushed a commit
to Pranjal095/cpython
that referenced
this pull request
Jul 12, 2025
…ed (pythonGH-135174) Co-authored-by: neonene <53406459+neonene@users.noreply.github.com>
taegyunkim
pushed a commit
to taegyunkim/cpython
that referenced
this pull request
Aug 4, 2025
…ed (pythonGH-135174) Co-authored-by: neonene <53406459+neonene@users.noreply.github.com>
Agent-Hellboy
pushed a commit
to Agent-Hellboy/cpython
that referenced
this pull request
Aug 19, 2025
…ed (pythonGH-135174) Co-authored-by: neonene <53406459+neonene@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The comment about free not being necessary is wrong. Like classes, modules need both clear and free.