FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

GH-132661: Add ``string.templatelib.convert()`` by AA-Turner · Pull Request #135217 · python/cpython · GitHub

/ cpython Public

GH-132661: Add string.templatelib.convert() - #135217

Merged
lysnikolaou merged 4 commits into
python:mainfrom
AA-Turner:templatelib-convert
Jul 15, 2025
ConversationCommits (4)ChecksFiles changed
Merged

GH-132661: Add string.templatelib.convert()#135217
lysnikolaou merged 4 commits into
python:mainfrom
AA-Turner:templatelib-convert

Conversation

AA-Turner commented Jun 6, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

See https://discuss.python.org/t/94569/. cc @davepeck @treyhunner.

Sketch implementation. Skip news as this would be part of the larger PEP 750 piece.

A

📚 Documentation preview 📚: https://cpython-previews--135217.org.readthedocs.build/

AA-Turner requested a review from lysnikolaou as a code owner June 6, 2025 14:53
bedevere-app Bot mentioned this pull request Jun 6, 2025
Closed

lysnikolaou commented Jul 10, 2025

Copy link
Copy Markdown
Member

There's some test failures here. @hugovk Would it be okay if we backported this to 3.14?

lysnikolaou reviewed Jul 10, 2025
View reviewed changes

lysnikolaou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Let's just add string.templatelib.convert in this PR and leave docs for the big docs PR that currently in review.

hugovk commented Jul 11, 2025

Copy link
Copy Markdown
Member

@hugovk Would it be okay if we backported this to 3.14?

Yes, this makes sense to be part of the PEP 750 stuff. RC1 is soon: 2025-07-22.

lysnikolaou commented Jul 15, 2025

Copy link
Copy Markdown
Member

@AA-Turner Are you going to work on this to simplify it down to just adding convert?

AA-Turner commented Jul 15, 2025

Copy link
Copy Markdown
Member Author

Yes, sorry (at EuroPython). Hopefully will have time this afternoon.

A

AA-Turner requested a review from lysnikolaou July 15, 2025 07:52
AA-Turner added the needs backport to 3.14 bugs and security fixes label Jul 15, 2025
lysnikolaou approved these changes Jul 15, 2025
View reviewed changes

lysnikolaou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM! Thanks @AA-Turner!

lysnikolaou merged commit 5b969fd into python:main Jul 15, 2025
46 checks passed

miss-islington-app Bot commented Jul 15, 2025

Copy link
Copy Markdown

Thanks @AA-Turner for the PR, and @lysnikolaou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 15, 2025
pythonGH-132661: Add string.templatelib.convert() (pythonGH-135217)
d0e51ee 
(cherry picked from commit 5b969fd)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>

bedevere-app Bot commented Jul 15, 2025

Copy link
Copy Markdown

GH-136671 is a backport of this pull request to the 3.14 branch.

AA-Turner deleted the templatelib-convert branch July 15, 2025 09:57
bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jul 15, 2025
AA-Turner mentioned this pull request Jul 15, 2025
Merged
AA-Turner added a commit that referenced this pull request Jul 15, 2025
[3.14] GH-132661: Add string.templatelib.convert() (GH-135217) (#…
2ae0eb1 
…136671)

GH-132661: Add ``string.templatelib.convert()`` (GH-135217)
(cherry picked from commit 5b969fd)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>

davepeck commented Jul 15, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

🎉 Thanks, @AA-Turner ! I'll add docs for this to #135229

taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
pythonGH-132661: Add string.templatelib.convert() (python#135217)
3f1d46f
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
pythonGH-132661: Add string.templatelib.convert() (python#135217)
81c76f3
kumaraditya303 pushed a commit to miss-islington/cpython that referenced this pull request Sep 9, 2025
[3.14] pythonGH-132661: Add string.templatelib.convert() (pythonG…
dfaf183 
…H-135217) (python#136671)

pythonGH-132661: Add ``string.templatelib.convert()`` (pythonGH-135217)
(cherry picked from commit 5b969fd)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
NickCrews added a commit to NickCrews/tstrings-backport that referenced this pull request Mar 11, 2026
feat: backport convert() function for API compatibility
8cb9ec9 
This was implemented upstream in python/cpython#135217
NickCrews mentioned this pull request Mar 11, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lysnikolaou lysnikolaou approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL