Repository navigation
gh-131798: Optimize _UNARY_INVERT - #135222
Merged
Fidget-Spinner merged 11 commits intoJun 9, 2025
Merged
Fidget-Spinner merged 11 commits into
Fidget-Spinner merged 11 commits into
Conversation
Fidget-Spinner
approved these changes
Jun 6, 2025
Fidget-Spinner
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
nice!
Sorry, something went wrong.
brandtbucher
approved these changes
Jun 6, 2025
brandtbucher
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Looks good, can you add a test for the bool case?
Sorry, something went wrong.
Comment thread
Python/optimizer_bytecodes.c
Outdated
Copy link
Copy Markdown
Contributor
Author
|
Thanks for reviewing @brandtbucher and @Fidget-Spinner. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Hm, I didn't realize we had deprecated bitwise inversion on bool. Let's just drop bool from the optimizer, it's not worth it. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
Sounds good |
Sorry, something went wrong.
lkollar
pushed a commit
to lkollar/cpython
that referenced
this pull request
Jun 19, 2025
Pranjal095
pushed a commit
to Pranjal095/cpython
that referenced
this pull request
Jul 12, 2025
taegyunkim
pushed a commit
to taegyunkim/cpython
that referenced
this pull request
Aug 4, 2025
Agent-Hellboy
pushed a commit
to Agent-Hellboy/cpython
that referenced
this pull request
Aug 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.