bpo-36876: Use a consistent variable name for kwlist. - #13531
Closed
ericsnowcurrently wants to merge 1 commit into
Closed
bpo-36876: Use a consistent variable name for kwlist.#13531ericsnowcurrently wants to merge 1 commit into
ericsnowcurrently wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
ericsnowcurrently
requested review from
berkerpeksag and
rhettinger
as code owners
May 23, 2019 22:55
Copy link
Copy Markdown
Member
|
I'm not super excited by PR only changing the coding style. Can't you use a tool which understand that the static is a constant and it's value is constant? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
You're right. :) |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Sorry :-( |
Sorry, something went wrong.
Open
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having a consistent variable name helps simplify efforts to identify C globals that need to be moved. (A consistent name is easier to ignore.)
https://bugs.python.org/issue36876