Repository navigation
[3.13] GH-135171: Roll back fix for GH-125038 as it's not suitable for 3.13 - #135403
Closed
efimov-mikhail wants to merge 1 commit into
Closed
efimov-mikhail wants to merge 1 commit into
efimov-mikhail wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
… suitable for 3.13
Copy link
Copy Markdown
Member
|
LGTM, but we just discussed this on Discord and @Yhg1s has a different opinion. So this PR will likely be rejected. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
As I can see, 3.13.5 was already released w/o this PR being merged. I close it, and we can apply it in the future, if there will be such a consesnus. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Roll back PR #125846 and add additional null check for FOR_ITER from #135225.
IMO, after this PR being merged all generator expression related bytecode will be reverted for 3.13.0 version.
cc @Yhg1s @serhiy-storchaka @markshannon