FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-135447: Update dis.rst to reflect 3.14 bytecode instructions by Ragna1204 · Pull Request #135478 · python/cpython · GitHub

/ cpython Public

gh-135447: Update dis.rst to reflect 3.14 bytecode instructions - #135478

Closed
Ragna1204 wants to merge 5 commits into
python:mainfrom
Ragna1204:fix-6876
ConversationCommits (5)ChecksFiles changed
Closed

gh-135447: Update dis.rst to reflect 3.14 bytecode instructions#135478
Ragna1204 wants to merge 5 commits into
python:mainfrom
Ragna1204:fix-6876

Conversation

Ragna1204 commented Jun 13, 2025 •
edited
Loading

Copy link
Copy Markdown

This pull request fixes #135478 by:

  • Adding documentation for new 3.14 bytecode instructions in dis.rst.
  • Updating the CALL_FUNCTION_EX opcode's description to reflect its 3.14 semantics.

The following instructions were added:

  • BUILD_INTERPOLATION
  • LOAD_SMALL_INT
  • NOT_TAKEN

This change brings the dis docs up to date with the 3.14 implementation.

See #135478 for more context.

📚 Documentation preview 📚: https://cpython-previews--135478.org.readthedocs.build/

python-cla-bot Bot commented Jun 13, 2025 •
edited
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

bedevere-app Bot added awaiting review docs Documentation in the Doc dir skip news labels Jun 13, 2025
github-project-automation Bot moved this to Todo in Docs PRs Jun 13, 2025
Ragna1204 changed the title Fix-6876: Update dis.rst to reflect 3.14 bytecode instructions and fixes to CALL_FUNCTION_EX gh-135447: Update dis.rst to reflect 3.14 bytecode instructions Jun 14, 2025
bedevere-app Bot mentioned this pull request Jun 14, 2025
Open
6 tasks
Ragna1204 changed the title gh-135447: Update dis.rst to reflect 3.14 bytecode instructions Fix-6876: Update dis.rst to reflect 3.14 bytecode instructions and fixes to CALL_FUNCTION_EX Jun 14, 2025
Ragna1204 changed the title Fix-6876: Update dis.rst to reflect 3.14 bytecode instructions and fixes to CALL_FUNCTION_EX gh-135447: Update dis.rst to reflect 3.14 bytecode instructions Jun 14, 2025

efimov-mikhail commented Jun 14, 2025

Copy link
Copy Markdown
Member

See #6876 for more context.

Is it correct link?

efimov-mikhail reviewed Jun 14, 2025
View reviewed changes
Comment thread Doc/library/dis.rst

.. versionadded:: 3.14


efimov-mikhail Jun 14, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Why this have been removed from Unary operations section?

Ragna1204 Jun 14, 2025

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I removed it because it was causing conflict in a check as it was mentioned twice. If its better then i can re add this here and remove the other mention

Comment thread Doc/library/dis.rst

``CALL_FUNCTION_EX`` pops all arguments and the callable object off the stack,
calls the callable object with those arguments, and pushes the return value
calls the callable with those arguments, and pushes the return value

efimov-mikhail Jun 14, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Is it better without "object" word?

efimov-mikhail commented Jun 14, 2025

Copy link
Copy Markdown
Member

Could you please provide here links to the exact PRs when these bytecodes are introduced?

Fidget-Spinner commented Jun 14, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

I feel like this PR was AI-generated. Either that or it is misguided. Most of the documentation here is factually incorrect.

Sorry in advance if the PR was not AI generated.

Ragna1204 commented Jun 14, 2025

Copy link
Copy Markdown
Author

Hi @efimov-mikhail and @Fidget-Spinner , sorry i was not focusing while writing the PR and added the link tag from some other project contribution i was doing. Thanks for pointing it out, i have fixed it now

efimov-mikhail commented Jun 14, 2025

Copy link
Copy Markdown
Member

Thanks for pointing it out, i have fixed it now

But for now it's just a link for this PR itself.

ZeroIntensity added the needs backport to 3.14 bugs and security fixes label Jun 15, 2025

Fidget-Spinner commented Jun 15, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

I'm really sorry but I'm closing this PR. I suspect while it's not AI written, AI might have been used while sourcing the changes to the bytecode. While I recommend AI usage for things like grammar and sentence structure, it's not an accurate nor reliable source to use.

Even if not AI-sourced, the content is almost entirely factually inaccurate, that it would take as much effort for me to rewrite the PR as to open a PR myself.

I'm really sorry again. Please let me know if you think I was mistaken somewhere.

Fidget-Spinner removed the needs backport to 3.14 bugs and security fixes label Jun 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

efimov-mikhail efimov-mikhail left review comments

Assignees

No one assigned

Labels

awaiting review docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Todo

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL