FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-135379: Add back const cast to _PyLong_IsCompact by Fidget-Spinner · Pull Request #135706 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-135379: Add back const cast to _PyLong_IsCompact - #135706

Merged
encukou merged 2 commits into
python:mainfrom
Fidget-Spinner:fix-const-cast
Jun 19, 2025
ConversationCommits (2)ChecksFiles changed
Merged

gh-135379: Add back const cast to _PyLong_IsCompact#135706
encukou merged 2 commits into
python:mainfrom
Fidget-Spinner:fix-const-cast

Conversation

Fidget-Spinner commented Jun 19, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

Fidget-Spinner changed the title gh-135668: Add back const cast to _PyLong_IsCompact gh-135379: Add back const cast to _PyLong_IsCompact Jun 19, 2025
bedevere-app Bot mentioned this pull request Jun 19, 2025
Closed

Fidget-Spinner commented Jun 19, 2025

Copy link
Copy Markdown
Member Author

!buildbot AMD64 Debian root 3.x

bedevere-bot commented Jun 19, 2025

Copy link
Copy Markdown

The regex 'AMD64 Debian root 3.x' did not match any buildbot builder. Is the requested builder in the list of stable builders?

Fidget-Spinner commented Jun 19, 2025

Copy link
Copy Markdown
Member Author

!buildbot AMD64 Debian root 3

bedevere-bot commented Jun 19, 2025

Copy link
Copy Markdown

The regex 'AMD64 Debian root 3' did not match any buildbot builder. Is the requested builder in the list of stable builders?

Fidget-Spinner commented Jun 19, 2025

Copy link
Copy Markdown
Member Author

!buildbot AMD64 CentOS9

bedevere-bot commented Jun 19, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @Fidget-Spinner for commit 991c098 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F135706%2Fmerge

The command will test the builders whose names match following regular expression: AMD64 CentOS9

The builders matched are:

  • AMD64 CentOS9 FIPS Only Blake2 Builtin Hash PR
  • AMD64 CentOS9 PR
  • AMD64 CentOS9 LTO PR
  • AMD64 CentOS9 LTO + PGO PR
  • AMD64 CentOS9 FIPS No Builtin Hashes PR
  • AMD64 CentOS9 NoGIL Refleaks PR
  • AMD64 CentOS9 NoGIL PR
  • AMD64 CentOS9 Refleaks PR

Fidget-Spinner commented Jun 19, 2025

Copy link
Copy Markdown
Member Author

!buildbot AMD64 CentOS9 NoGIL PR

bedevere-bot commented Jun 19, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @Fidget-Spinner for commit 219d9d1 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F135706%2Fmerge

The command will test the builders whose names match following regular expression: AMD64 CentOS9 NoGIL PR

The builders matched are:

  • AMD64 CentOS9 NoGIL PR

Fidget-Spinner commented Jun 19, 2025
View reviewed changes
Comment thread Include/cpython/longintrepr.h

static inline int
PyLong_CheckCompact(const PyObject *op)
PyLong_CheckCompact(PyObject *op)

Fidget-Spinner Jun 19, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

We need to use PyObject * here because PyLong_CheckExact casts to PyObject * which discards the const qualifier.

python deleted a comment from murtazox04 Jun 19, 2025
encukou merged commit 1b969f6 into python:main Jun 19, 2025
Fidget-Spinner deleted the fix-const-cast branch June 19, 2025 12:17
lkollar pushed a commit to lkollar/cpython that referenced this pull request Jun 19, 2025
pythongh-135379: Add back const cast to _PyLong_IsCompact (pythonGH-1…
5ee00d3 
…35706)
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
pythongh-135379: Add back const cast to _PyLong_IsCompact (pythonGH-1…
15ca4e1 
…35706)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
pythongh-135379: Add back const cast to _PyLong_IsCompact (pythonGH-1…
977dd64 
…35706)
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
pythongh-135379: Add back const cast to _PyLong_IsCompact (pythonGH-1…
04f0385 
…35706)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

markshannon Awaiting requested review from markshannon

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL