Repository navigation
gh-135379: Move PyLong_CheckCompact to private header - #135707
Merged
Fidget-Spinner merged 2 commits intoJun 19, 2025
Merged
Fidget-Spinner merged 2 commits into
Fidget-Spinner merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
|
Since you're moving/renaming it: should this be PyLong_CheckExactAndCompact, to reduce confusion with _PyLong_IsCompact/PyUnstable_Long_IsCompact? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Good point, I renamed it. |
Sorry, something went wrong.
encukou
approved these changes
Jun 19, 2025
Fidget-Spinner
enabled auto-merge (squash)
June 19, 2025 12:30
vstinner
approved these changes
Jun 19, 2025
vstinner
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
lkollar
pushed a commit
to lkollar/cpython
that referenced
this pull request
Jun 19, 2025
Pranjal095
pushed a commit
to Pranjal095/cpython
that referenced
this pull request
Jul 12, 2025
taegyunkim
pushed a commit
to taegyunkim/cpython
that referenced
this pull request
Aug 4, 2025
Agent-Hellboy
pushed a commit
to Agent-Hellboy/cpython
that referenced
this pull request
Aug 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.