FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-134584: Specialize POP_TOP by reference and type in JIT by Fidget-Spinner · Pull Request #135761 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-134584: Specialize POP_TOP by reference and type in JIT - #135761

Merged
Fidget-Spinner merged 9 commits into
python:mainfrom
Fidget-Spinner:eliminate_store_fast_refcount
Jun 23, 2025
ConversationCommits (9)ChecksFiles changed
Merged

gh-134584: Specialize POP_TOP by reference and type in JIT#135761
Fidget-Spinner merged 9 commits into
python:mainfrom
Fidget-Spinner:eliminate_store_fast_refcount

Conversation

Fidget-Spinner commented Jun 20, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

bedevere-app Bot mentioned this pull request Jun 20, 2025
Closed
35 tasks done
markshannon reviewed Jun 20, 2025
View reviewed changes

markshannon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Very nice.

You can streamline the optimization a bit using sym_is_immortal and you might want to add a test for optimizing the POP_TOP after a call that returns None.

Comment thread Python/optimizer_bytecodes.c
Comment thread Python/optimizer_bytecodes.c Outdated
markshannon reviewed Jun 20, 2025
View reviewed changes
Comment thread Python/bytecodes.c Outdated
Fidget-Spinner commented Jun 20, 2025
View reviewed changes
Comment thread Python/optimizer_bytecodes.c
JitOptRef temp = retval;
// We wrap and unwrap the value to mimic PyStackRef_MakeHeapSafe
// in bytecodes.c
JitOptRef temp = PyJitRef_Wrap(PyJitRef_Unwrap(retval));

Fidget-Spinner Jun 20, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This was a bug in the previous implementation. This was only exposed in this PR.

Fidget-Spinner commented Jun 22, 2025
View reviewed changes
Comment thread Python/optimizer_symbols.c
if (sym->tag == JIT_SYM_KNOWN_CLASS_TAG) {
return sym->cls.type == &PyBool_Type;
}
if (sym->tag == JIT_SYM_TRUTHINESS_TAG) {

Fidget-Spinner Jun 22, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

A truthiness is not immortal. This is a false asumption.

corona10 mentioned this pull request Jun 22, 2025
Closed
tomasr8 mentioned this pull request Jun 22, 2025
Merged
markshannon approved these changes Jun 23, 2025
View reviewed changes

markshannon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good.

This should wait for TOS caching, otherwise it is adding overhead to STORE_FAST. But once that is in, this makes a nice improvement.

Fidget-Spinner changed the title gh-134584: Specialize STORE_FAST by reference and type in JIT gh-134584: Specialize POP_TOP by reference and type in JIT Jun 23, 2025
Fidget-Spinner merged commit 569fc68 into python:main Jun 23, 2025
Fidget-Spinner deleted the eliminate_store_fast_refcount branch June 23, 2025 16:57
AndPuQing pushed a commit to AndPuQing/cpython that referenced this pull request Jul 11, 2025
pythongh-134584: Specialize POP_TOP by reference and type in JIT (pyt…
a126c1a 
…honGH-135761)
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
pythongh-134584: Specialize POP_TOP by reference and type in JIT (pyt…
2065428 
…honGH-135761)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
pythongh-134584: Specialize POP_TOP by reference and type in JIT (pyt…
e635044 
…honGH-135761)
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
pythongh-134584: Specialize POP_TOP by reference and type in JIT (pyt…
dae1d14 
…honGH-135761)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

brianschubert brianschubert left review comments
markshannon markshannon approved these changes
tomasr8 Awaiting requested review from tomasr8 tomasr8 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL