FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-135815: skip `netrc` security checks if `os.getuid` is missing by picnixz · Pull Request #135816 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-135815: skip netrc security checks if os.getuid is missing - #135816

Merged
picnixz merged 2 commits into
python:mainfrom
picnixz:fix/netrc/wasi-security-check-135815
Jun 22, 2025
ConversationCommits (2)ChecksFiles changed
Merged

gh-135815: skip netrc security checks if os.getuid is missing#135816
picnixz merged 2 commits into
python:mainfrom
picnixz:fix/netrc/wasi-security-check-135815

Conversation

picnixz commented Jun 22, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

bedevere-app Bot mentioned this pull request Jun 22, 2025
Closed
picnixz force-pushed the fix/netrc/wasi-security-check-135815 branch from c472cc9 to d2a13f6 Compare June 22, 2025 14:34
picnixz added needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes labels Jun 22, 2025
python deleted a comment from bedevere-bot Jun 22, 2025
picnixz requested a review from serhiy-storchaka June 22, 2025 15:06
serhiy-storchaka approved these changes Jun 22, 2025
View reviewed changes

serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM.

Added a couple of suggestions, it is up to you.

Comment thread Lib/netrc.py Outdated
Comment thread Lib/netrc.py
Comment on lines 164 to 165
(f"~/.netrc file owner ({fowner}, {user}) does not match"
" current user"))

serhiy-storchaka Jun 22, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The message looks weird. Would not be better to rewrite in in the following way?

                    (f"~/.netrc file owner ({fowner}) does not match"
                     f" current user ({user})"))

picnixz Jun 22, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'll change it in a follow-up PR so that only unstable branches are affected.

picnixz enabled auto-merge (squash) June 22, 2025 19:31
picnixz merged commit b57b619 into python:main Jun 22, 2025

miss-islington-app Bot commented Jun 22, 2025

Copy link
Copy Markdown

Thanks @picnixz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 22, 2025
pythongh-135815: skip netrc security checks if os.getuid is missi…
1f82438 
…ng (pythonGH-135816)

(cherry picked from commit b57b619)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

bedevere-app Bot commented Jun 22, 2025

Copy link
Copy Markdown

GH-135825 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jun 22, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 22, 2025
pythongh-135815: skip netrc security checks if os.getuid is missi…
da2e45c 
…ng (pythonGH-135816)

(cherry picked from commit b57b619)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

bedevere-app Bot commented Jun 22, 2025

Copy link
Copy Markdown

GH-135826 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jun 22, 2025
picnixz deleted the fix/netrc/wasi-security-check-135815 branch June 22, 2025 19:49
picnixz added a commit that referenced this pull request Jun 22, 2025
[3.13] gh-135815: skip netrc security checks if os.getuid is miss…
6e0ad71 
…ing (GH-135816) (#135826)

gh-135815: skip `netrc` security checks if `os.getuid` is missing (GH-135816)
(cherry picked from commit b57b619)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
picnixz added a commit that referenced this pull request Jun 22, 2025
[3.14] gh-135815: skip netrc security checks if os.getuid is miss…
10f9db9 
…ing (GH-135816) (#135825)

gh-135815: skip `netrc` security checks if `os.getuid` is missing (GH-135816)
(cherry picked from commit b57b619)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

bedevere-bot commented Jun 23, 2025

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot aarch64 Fedora Stable Refleaks 3.14 (tier-2) has failed when building commit 10f9db9.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1710/builds/192) and take a look at the build logs.
  4. Check if the failure is related to this commit (10f9db9) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1710/builds/192

Failed tests:

  • test_perf_profiler

Failed subtests:

  • test_python_calls_do_not_appear_in_the_stack_if_perf_deactivated - test.test_perf_profiler.TestPerfProfilerWithDwarf.test_python_calls_do_not_appear_in_the_stack_if_perf_deactivated
  • test_timerfd_select - test.test_os.TimerfdTests.test_timerfd_select
  • test_python_calls_appear_in_the_stack_if_perf_activated - test.test_perf_profiler.TestPerfProfilerWithDwarf.test_python_calls_appear_in_the_stack_if_perf_activated

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.14.cstratak-fedora-stable-aarch64.refleak/build/Lib/test/test_perf_profiler.py", line 399, in test_python_calls_do_not_appear_in_the_stack_if_perf_deactivated
    self.assertEqual(stderr, "")
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^
AssertionError: 'Warning:\nProcessed 403 events and lost 1[34 chars]\n\n' != ''
- Warning:
- Processed 403 events and lost 1 chunks!
- 
- Check IO/CPU overload!
- 


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.14.cstratak-fedora-stable-aarch64.refleak/build/Lib/test/test_perf_profiler.py", line 399, in test_python_calls_do_not_appear_in_the_stack_if_perf_deactivated
    self.assertEqual(stderr, "")
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^
AssertionError: 'Warning:\nProcessed 429 events and lost 1[34 chars]\n\n' != ''
- Warning:
- Processed 429 events and lost 1 chunks!
- 
- Check IO/CPU overload!
- 


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.14.cstratak-fedora-stable-aarch64.refleak/build/Lib/test/test_perf_profiler.py", line 373, in test_python_calls_appear_in_the_stack_if_perf_activated
    self.assertEqual(stderr, "")
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^
AssertionError: 'Warning:\nProcessed 653 events and lost 1[34 chars]\n\n' != ''
- Warning:
- Processed 653 events and lost 1 chunks!
- 
- Check IO/CPU overload!
- 


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.14.cstratak-fedora-stable-aarch64.refleak/build/Lib/test/test_os.py", line 4450, in test_timerfd_select
    self.assertEqual(self.read_count_signaled(fd), 1)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 2 != 1

hoodmane added a commit to hoodmane/cpython that referenced this pull request Jul 3, 2025
pythongh-127146: Skip test_netrc.test_security on Emscripten
6b0c452 
Before python#135816 it was skipped because pwd is missing on Emscripten.
Now it isn't skipped because the test no longer requires pwd but it
still doesn't work on Emscripten.
hoodmane mentioned this pull request Jul 3, 2025
Closed
AndPuQing pushed a commit to AndPuQing/cpython that referenced this pull request Jul 11, 2025
pythongh-135815: skip netrc security checks if os.getuid is missi…
c620360 
…ng (python#135816)
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
pythongh-135815: skip netrc security checks if os.getuid is missi…
6ed74fb 
…ng (python#135816)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
pythongh-135815: skip netrc security checks if os.getuid is missi…
01bb4ef 
…ng (python#135816)
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
pythongh-135815: skip netrc security checks if os.getuid is missi…
75935fc 
…ng (python#135816)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

serhiy-storchaka serhiy-storchaka approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL