FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-135855: Fix `SystemError` when passing non-dict object to `_interpreters.set___main___attrs` by brianschubert · Pull Request #135856 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-135855: Fix SystemError when passing non-dict object to _interpreters.set___main___attrs - #135856

Merged
ericsnowcurrently merged 2 commits into
python:mainfrom
brianschubert:gh-135855-interpreters-systemerror-set-main-attrs
Jun 24, 2025
ConversationCommits (2)ChecksFiles changed
Merged

gh-135855: Fix SystemError when passing non-dict object to _interpreters.set___main___attrs#135856
ericsnowcurrently merged 2 commits into
python:mainfrom
brianschubert:gh-135855-interpreters-systemerror-set-main-attrs

Conversation

brianschubert commented Jun 23, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

bedevere-app Bot mentioned this pull request Jun 23, 2025
Closed
brianschubert added needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes labels Jun 23, 2025
sobolevn approved these changes Jun 24, 2025
View reviewed changes

sobolevn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM!

sergey-miryanov reviewed Jun 24, 2025
View reviewed changes
Comment thread Modules/_interpretersmodule.c Outdated
ericsnowcurrently approved these changes Jun 24, 2025
View reviewed changes

ericsnowcurrently left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

ericsnowcurrently merged commit 4e6f0d1 into python:main Jun 24, 2025

miss-islington-app Bot commented Jun 24, 2025

Copy link
Copy Markdown

Thanks @brianschubert for the PR, and @ericsnowcurrently for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 24, 2025
pythongh-135855: Raise TypeError When Passing Non-dict Object to `_in…
f9f1172 
…terpreters.set___main___attrs` (pythongh-135856)

(cherry picked from commit 4e6f0d1)

Co-authored-by: Brian Schubert <brianm.schubert@gmail.com>

miss-islington-app Bot commented Jun 24, 2025

Copy link
Copy Markdown

Sorry, @brianschubert and @ericsnowcurrently, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 4e6f0d116e9725efb2d8eb6c3274aa3c024a6fb4 3.13

bedevere-app Bot commented Jun 24, 2025

Copy link
Copy Markdown

GH-135900 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jun 24, 2025
ericsnowcurrently added 3.13 only security fixes needs backport to 3.13 only security fixes and removed needs backport to 3.13 only security fixes 3.13 only security fixes labels Jun 24, 2025

miss-islington-app Bot commented Jun 24, 2025

Copy link
Copy Markdown

Thanks @brianschubert for the PR, and @ericsnowcurrently for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington-app Bot commented Jun 24, 2025

Copy link
Copy Markdown

Sorry, @brianschubert and @ericsnowcurrently, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 4e6f0d116e9725efb2d8eb6c3274aa3c024a6fb4 3.13

ericsnowcurrently commented Jun 24, 2025

Copy link
Copy Markdown
Member

@brianschubert, would you mind manually creating a backport PR for 3.13?

ericsnowcurrently pushed a commit that referenced this pull request Jun 24, 2025
[3.14] gh-135855: Raise TypeError When Passing Non-dict Object to `_i…
090a42b 
…nterpreters.set___main___attrs` (gh-135900)

(cherry picked from commit 4e6f0d1, AKA gh-135856)

Co-authored-by: Brian Schubert <brianm.schubert@gmail.com>
brianschubert added a commit to brianschubert/cpython that referenced this pull request Jun 24, 2025
[3.13] pythongh-135855: Raise TypeError When Passing Non-dict Object …
d33628e 
…to `_interpreters.set___main___attrs` (pythongh-135856)

(cherry picked from commit 4e6f0d1)

Co-authored-by: Brian Schubert <brianm.schubert@gmail.com>

bedevere-app Bot commented Jun 24, 2025

Copy link
Copy Markdown

GH-135903 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jun 24, 2025
ericsnowcurrently pushed a commit that referenced this pull request Jun 24, 2025
[3.13] gh-135855: Raise TypeError When Passing Non-dict Object to `_i…
3e43628 
…nterpreters.set___main___attrs` (gh-135903)

(cherry picked from commit 4e6f0d1, AKA gh-135856)
AndPuQing pushed a commit to AndPuQing/cpython that referenced this pull request Jul 11, 2025
pythongh-135855: Raise TypeError When Passing Non-dict Object to `_in…
d76582d 
…terpreters.set___main___attrs` (pythongh-135856)
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
pythongh-135855: Raise TypeError When Passing Non-dict Object to `_in…
bf3647b 
…terpreters.set___main___attrs` (pythongh-135856)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
pythongh-135855: Raise TypeError When Passing Non-dict Object to `_in…
1bcf576 
…terpreters.set___main___attrs` (pythongh-135856)
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
pythongh-135855: Raise TypeError When Passing Non-dict Object to `_in…
9cc402f 
…terpreters.set___main___attrs` (pythongh-135856)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

sergey-miryanov sergey-miryanov left review comments
sobolevn sobolevn approved these changes
ericsnowcurrently ericsnowcurrently approved these changes
+1 more reviewer
blockchainGuru1018 blockchainGuru1018 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

ericsnowcurrently

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL