Repository navigation
gh-135853: add math.fmax and math.fmin - #135888
Merged
picnixz merged 13 commits intoJul 12, 2025
Merged
picnixz merged 13 commits into
picnixz merged 13 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
picnixz
commented
Jun 24, 2025
Comment thread
Modules/mathmodule.c
Outdated
skirpichev
reviewed
Jun 24, 2025
picnixz
force-pushed
the
feat/math/fmin-fmax-135853
branch
from
0831229 to
afb0a91
Compare
June 24, 2025 14:30
picnixz
commented
Jun 24, 2025
Comment thread
Lib/test/test_math.py
Outdated
picnixz
commented
Jun 24, 2025
Comment thread
Lib/test/test_math.py
Outdated
vstinner
reviewed
Jun 24, 2025
Comment thread
Lib/test/test_math.py
Outdated
Comment thread
Lib/test/test_math.py
Comment thread
Lib/test/test_math.py
Outdated
picnixz
commented
Jun 27, 2025
Comment thread
Misc/NEWS.d/next/Library/2025-06-24-13-30-47.gh-issue-135853.7ejTvK.rst
Outdated
Comment thread
Modules/mathmodule.c
Outdated
Comment thread
Doc/library/math.rst
Outdated
vstinner
approved these changes
Jun 27, 2025
vstinner
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
skirpichev
approved these changes
Jun 27, 2025
Comment thread
Doc/library/math.rst
Outdated
Comment thread
Doc/library/math.rst
Outdated
Comment thread
Lib/test/test_math.py
Outdated
Comment thread
Lib/test/test_math.py
Outdated
Comment thread
Lib/test/test_math.py
Outdated
Comment thread
Doc/library/math.rst
Comment thread
Doc/library/math.rst
Comment thread
Lib/test/test_math.py
Outdated
Comment thread
Lib/test/test_math.py
Outdated
Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
picnixz
commented
Jun 27, 2025
Comment thread
Lib/test/test_math.py
Outdated
picnixz
commented
Jun 27, 2025
Comment thread
Lib/test/test_math.py
Outdated
skirpichev
reviewed
Jun 28, 2025
Comment thread
Doc/library/math.rst
Comment thread
Doc/library/math.rst
Outdated
Comment thread
Doc/library/math.rst
Outdated
Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
picnixz
enabled auto-merge (squash)
July 12, 2025 11:06
Pranjal095
pushed a commit
to Pranjal095/cpython
that referenced
this pull request
Jul 12, 2025
picnixz
added a commit
to picnixz/cpython
that referenced
this pull request
Jul 13, 2025
taegyunkim
pushed a commit
to taegyunkim/cpython
that referenced
this pull request
Aug 4, 2025
Agent-Hellboy
pushed a commit
to Agent-Hellboy/cpython
that referenced
this pull request
Aug 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added math.fmin and math.fmax as I think it'd be nice to have the NaN handling as per C99. I didn't make those functions generic or accept any iterable argument.
WDYT of this proposal @skirpichev @rhettinger?
📚 Documentation preview 📚: https://cpython-previews--135888.org.readthedocs.build/