gh-135755: Use private names (_Py*) for header file guards new in 3.14 - #135921
Merged
encukou merged 1 commit intoJun 26, 2025
Merged
gh-135755: Use private names (_Py*) for header file guards new in 3.14#135921encukou merged 1 commit into
encukou merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
…in 3.14 These are private API; let's name new ones accordingly.
39 tasks
Copy link
Copy Markdown
|
Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 26, 2025
…in 3.14 (pythonGH-135921) These are private API; let's name new ones accordingly. (cherry picked from commit 6be17ba) Co-authored-by: Petr Viktorin <encukou@gmail.com>
Copy link
Copy Markdown
|
GH-135976 is a backport of this pull request to the 3.14 branch. |
Sorry, something went wrong.
encukou
added a commit
that referenced
this pull request
Jul 1, 2025
Copy link
Copy Markdown
⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️Hi! The buildbot AMD64 Ubuntu Shared 3.14 (tier-1) has failed when building commit 665a682. What do you need to do:
You can take a look at the buildbot page here: https://buildbot.python.org/#/builders/1802/builds/251 Failed tests:
Failed subtests:
Summary of the results of the build (if available): == Click to see traceback logsTraceback (most recent call last):
File "/srv/buildbot/buildarea/3.14.bolen-ubuntu/build/Lib/test/test_external_inspection.py", line 991, in test_only_active_thread
self.assertEqual(len(gil_traces), 1, "Should have exactly one GIL holder")
~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 0 != 1 : Should have exactly one GIL holder
|
Sorry, something went wrong.
AndPuQing
pushed a commit
to AndPuQing/cpython
that referenced
this pull request
Jul 11, 2025
…in 3.14 (pythonGH-135921) These are private API; let's name new ones accordingly.
Pranjal095
pushed a commit
to Pranjal095/cpython
that referenced
this pull request
Jul 12, 2025
…in 3.14 (pythonGH-135921) These are private API; let's name new ones accordingly.
taegyunkim
pushed a commit
to taegyunkim/cpython
that referenced
this pull request
Aug 4, 2025
…in 3.14 (pythonGH-135921) These are private API; let's name new ones accordingly.
Agent-Hellboy
pushed a commit
to Agent-Hellboy/cpython
that referenced
this pull request
Aug 19, 2025
…in 3.14 (pythonGH-135921) These are private API; let's name new ones accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are private; let's name new ones accordingly.